From: Tejun Heo <tj@kernel.org>
To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc: Waiman Long <longman@redhat.com>,
Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
dan.carpenter@linaro.org, kernel-janitors@vger.kernel.org,
error27@gmail.com, kamalesh.babulal@oracle.com,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH next] cgroup/cpuset: Cleanup signedness issue in cpu_exclusive_check()
Date: Wed, 4 Oct 2023 08:59:21 -1000 [thread overview]
Message-ID: <ZR22CYkZCv52AmML@slm.duckdns.org> (raw)
In-Reply-To: <20230927065801.2139969-1-harshit.m.mogalapalli@oracle.com>
On Tue, Sep 26, 2023 at 11:58:01PM -0700, Harshit Mogalapalli wrote:
> Smatch complains about returning negative error codes from a type
> bool function.
>
> kernel/cgroup/cpuset.c:705 cpu_exclusive_check() warn:
> signedness bug returning '(-22)'
>
> The code works correctly, but it is confusing. The current behavior is
> that cpu_exclusive_check() returns true if it's *NOT* exclusive. Rename
> it to cpusets_are_exclusive() and reverse the returns so it returns true
> if it is exclusive and false if it's not. Update both callers as well.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Closes: https://lore.kernel.org/r/202309201706.2LhKdM6o-lkp@intel.com/
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Applied to cgroup/for-6.7.
Thanks.
--
tejun
prev parent reply other threads:[~2023-10-04 19:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 6:58 Harshit Mogalapalli
2023-09-27 9:37 ` Kamalesh Babulal
2023-09-27 13:13 ` Waiman Long
2023-10-04 18:59 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZR22CYkZCv52AmML@slm.duckdns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=error27@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=kamalesh.babulal@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=lkp@intel.com \
--cc=longman@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®