From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77FD6CE7A89 for ; Mon, 25 Sep 2023 07:22:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231695AbjIYHWu (ORCPT ); Mon, 25 Sep 2023 03:22:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232041AbjIYHWi (ORCPT ); Mon, 25 Sep 2023 03:22:38 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E9B0C2; Mon, 25 Sep 2023 00:22:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695626545; x=1727162545; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=EX/fS3GBRqS4B+ZBKLxnCaUT2he9dlkGETXA9I0BbhI=; b=aJRYAZgp3UR1fjRG50XuWeK01GtSisObc7jVtyHTTaUCUbDP0/yJ1Ckr FJYUTylYMF1kjZpdrGcfTD8Vm6pSmGkoThzhpn0L/W5iVDZx5PtguafSc uG8vC5wjLk++RjyNEQYPJIRwRzKvPv0E97Wnr/91Ul07l+CSV9WbsFjBK O2fJHRqmC2ajiOT08UOFhQZGqZffdZ28ZJZQNh+0B0K99XJWNfyg00pXt qRwjnVMyqGrlXFnvphb5zjmubI0SXHD9DKuwVKR9/JzXp8MaL+d6HDXro YUC2iVwR4atOq21y1ha/haPZP9v2FpenYf/AvPE+z97uIaikiVAe1on3q Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="360571552" X-IronPort-AV: E=Sophos;i="6.03,174,1694761200"; d="scan'208";a="360571552" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2023 00:22:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="1079117832" X-IronPort-AV: E=Sophos;i="6.03,174,1694761200"; d="scan'208";a="1079117832" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga005.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2023 00:22:23 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC0) (envelope-from ) id 1qkfv9-00000000HHI-3rPn; Mon, 25 Sep 2023 10:22:19 +0300 Date: Mon, 25 Sep 2023 10:22:19 +0300 From: Andy Shevchenko To: Biju Das Cc: Pavel Machek , Lee Jones , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Biju Das Subject: Re: [PATCH v2 2/2] leds: pca955x: Cleanup OF/ID table terminators Message-ID: References: <20230923171921.53503-1-biju.das.jz@bp.renesas.com> <20230923171921.53503-3-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230923171921.53503-3-biju.das.jz@bp.renesas.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 23, 2023 at 06:19:21PM +0100, Biju Das wrote: > Some cleanups: > * Remove the trailing comma in the terminator entry for the OF > table making code robust against (theoretical) misrebases or other > similar things where the new entry goes _after_ the termination without > the compiler noticing. > * Drop a space from terminator entry for ID table. > > While at it, move OF/ID table near to the user. OK! Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko