From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92687CE79A7 for ; Mon, 25 Sep 2023 22:29:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232466AbjIYW3P (ORCPT ); Mon, 25 Sep 2023 18:29:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229509AbjIYW3O (ORCPT ); Mon, 25 Sep 2023 18:29:14 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D60319C for ; Mon, 25 Sep 2023 15:29:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vThqe82wFHQYIn4iDqh4uJHLDDFlNPpTiNpJ978Vj4w=; b=Yxyn0YvHU4ijOJFKxi40NVpG6M 10klXG5q6CbXoKlZpEsiC4AWoeYkjSu132p0eMfW+ZAxsOmDmeYwKI6dNPA3d2tfgkNfSDAKnB2wR DjQesKO6BHO4cB0jcWm+aeDhgN67vj8/Rp03RudAOWasWtUB/QGq1Oq1j1mUUkzrMLXS6/HO/ZddY +bCIB7v1bXRyyI4Kdpt1rgIGsItdmHsTLkW697DshfEMLKUzq4BbXOZ/yUxTipdnAz7cVv0EIkmm2 b/gO6ecZMT0m3fmjJUWoS5Yk++88IhoKeBLFGo1JEaO2OjpFFOZi/XG/PXaMjR9tWmiSCjx6HCbKK BNMPCCqA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qku4G-0040tr-Jy; Mon, 25 Sep 2023 22:28:40 +0000 Date: Mon, 25 Sep 2023 23:28:40 +0100 From: Matthew Wilcox To: Hugh Dickins Cc: Andrew Morton , Andi Kleen , Christoph Lameter , Mike Kravetz , David Hildenbrand , Suren Baghdasaryan , Yang Shi , Sidhartha Kumar , Vishal Moola , Kefeng Wang , Greg Kroah-Hartman , Tejun Heo , Mel Gorman , Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 05/12] mempolicy trivia: slightly more consistent naming Message-ID: References: <2d872cef-7787-a7ca-10e-9d45a64c80b4@google.com> <1a75d3dd-7fa-7a41-c76b-1232198a9a4a@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1a75d3dd-7fa-7a41-c76b-1232198a9a4a@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 25, 2023 at 01:26:55AM -0700, Hugh Dickins wrote: > Before getting down to work, do a little cleanup, mainly of inconsistent > variable naming. I gave up trying to rationalize mpol versus pol versus > policy, and node versus nid, but let's avoid p and nd. Remove a few > superfluous blank lines, but add one; and here prefer vma->vm_policy to > vma_policy(vma) - the latter being appropriate in other sources, which > have to allow for !CONFIG_NUMA. That intriguing line about KERNEL_DS? > should have gone in v2.6.15, when numa_policy_init() stopped using > set_mempolicy(2)'s system call handler. Reviewed-by: Matthew Wilcox (Oracle)