mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: huangli05 <huangli05@inspur.com>, Greg KH <gregkh@linuxfoundation.org>
Cc: <osmtendev@gmail.com>, <speakup@linux-speakup.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] staging: speakup: Remove repeated word in comments
Date: Tue, 26 Sep 2023 08:05:07 +0700	[thread overview]
Message-ID: <ZRIuQ65mCABdhKLk@debian.me> (raw)
In-Reply-To: <20230925054559.3857-1-huangli05@inspur.com>

[-- Attachment #1: Type: text/plain, Size: 2149 bytes --]

On Mon, Sep 25, 2023 at 01:45:59PM +0800, huangli05 wrote:
> Remove the repeated word "the" in comments.
> 
> Signed-off-by: huangli05 <huangli05@inspur.com>
> ---
>  drivers/accessibility/speakup/speakup_soft.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/accessibility/speakup/speakup_soft.c b/drivers/accessibility/speakup/speakup_soft.c
> index 6d446824677b..6549bfb96e7f 100644
> --- a/drivers/accessibility/speakup/speakup_soft.c
> +++ b/drivers/accessibility/speakup/speakup_soft.c
> @@ -446,7 +446,7 @@ static int softsynth_adjust(struct spk_synth *synth, struct st_var_header *var)
>  	if (var->var_id != PUNC_LEVEL)
>  		return 0;
>  
> -	/* We want to set the the speech synthesis punctuation level
> +	/* We want to set the speech synthesis punctuation level
>  	 * accordingly, so it properly tunes speaking A_PUNC characters */
>  	var_data = var->data;
>  	if (!var_data)

You have not addressed Greg's patch email bot warnings from your v1 patch
yet [1], so I repeat it:

> - You did not specify a description of why the patch is needed, or
>   possibly, any description at all, in the email body.  Please read the
>   section entitled "The canonical patch format" in the kernel file,
>   Documentation/process/submitting-patches.rst for what is needed in
>   order to properly describe the change.
> 
> - You did not write a descriptive Subject: for the patch, allowing Greg,
>   and everyone else, to know what this patch is all about.  Please read
>   the section entitled "The canonical patch format" in the kernel file,
>   Documentation/process/submitting-patches.rst for what a proper
>   Subject: line should look like.
> 
> - It looks like you did not use your "real" name for the patch on either
>   the Signed-off-by: line, or the From: line (both of which have to
>   match).  Please read the kernel file,
>   Documentation/process/submitting-patches.rst for how to do this
>   correctly.

Thanks.

[1]: https://lore.kernel.org/all/20230921021349.3350-1-huangli05@inspur.com/

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      reply	other threads:[~2023-09-26  1:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-25  5:45 huangli05
2023-09-26  1:05 ` Bagas Sanjaya [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZRIuQ65mCABdhKLk@debian.me \
    --to=bagasdotme@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=huangli05@inspur.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=osmtendev@gmail.com \
    --cc=speakup@linux-speakup.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®