From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6784BE7D252 for ; Tue, 26 Sep 2023 08:15:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233963AbjIZIPl (ORCPT ); Tue, 26 Sep 2023 04:15:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233911AbjIZIPa (ORCPT ); Tue, 26 Sep 2023 04:15:30 -0400 Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C6C510A for ; Tue, 26 Sep 2023 01:15:20 -0700 (PDT) Received: from francesco-nb.int.toradex.com (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 1C88E207A2; Tue, 26 Sep 2023 10:15:16 +0200 (CEST) Date: Tue, 26 Sep 2023 10:14:54 +0200 From: Francesco Dolcini To: Emanuele Ghidoli Cc: Dmitry Torokhov , Emanuele Ghidoli , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Joe Hung Subject: Re: [PATCH v2 2/2] Input: ilitek_ts_i2c - add report id message validation Message-ID: References: <20230920074650.922292-1-ghidoliemanuele@gmail.com> <20230920074650.922292-3-ghidoliemanuele@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230920074650.922292-3-ghidoliemanuele@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 20, 2023 at 09:46:50AM +0200, Emanuele Ghidoli wrote: > From: Emanuele Ghidoli > > Ilitek touch IC driver answer to plain i2c read request, after it has > generated an interrupt request, with a report id message starting > with an identifier and a series of points. > If a request is sent unsolicited by an interrupt request the answer > do not contain this identifier. > Add a test to discard these messages, making the driver robust to > spurious interrupt requests. > > Fixes: 42370681bd46 ("Input: Add support for ILITEK Lego Series") > Signed-off-by: Emanuele Ghidoli Reviewed-by: Francesco Dolcini Francesco