From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 744C3E748EE for ; Sun, 1 Oct 2023 09:17:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234707AbjJAJRf (ORCPT ); Sun, 1 Oct 2023 05:17:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234641AbjJAJRd (ORCPT ); Sun, 1 Oct 2023 05:17:33 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABCFBAC; Sun, 1 Oct 2023 02:17:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696151852; x=1727687852; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=oCG7jOCcU3wYWkbsh+OYQxwNNnSBA4Q4h2ZKv3nOzPc=; b=aXtbdmGLtkeGyjApW/PIsk2xTx/vX1GH/cOUVyE6Vuy5AhV6TTcdEYgf 9Dn0BOXqQhTGtQHCUI0fzD2NODr5oxsx4RBWg9dLhWvlvVJPZKuWEQnxz wu5IxQ0nRyzt9miK6BAJ/oIRd1uhOHsddlAVFOZJPC/TbqcQhosXzCgZB cl+gagjWGZsZbhiBqsztiDnPSrwQWFnMtTS+JURali5FDXdlh3j5x66IB qPVg61tlTTpPdkYR04CgNXcLelk5UZc7iu+0flYb4R3lExASdgioGRgbI /Hi91i2Wl4hTc4Ku2niq8p6hGjVKY6k4a1PkhBse+UllWWWZa7wFwt/wu A==; X-IronPort-AV: E=McAfee;i="6600,9927,10849"; a="4084909" X-IronPort-AV: E=Sophos;i="6.03,191,1694761200"; d="scan'208";a="4084909" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2023 02:17:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10849"; a="924002428" X-IronPort-AV: E=Sophos;i="6.03,191,1694761200"; d="scan'208";a="924002428" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2023 02:17:28 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC0) (envelope-from ) id 1qmsZp-00000001rVH-16dD; Sun, 01 Oct 2023 12:17:25 +0300 Date: Sun, 1 Oct 2023 12:17:24 +0300 From: Andy Shevchenko To: Hans de Goede Cc: Bartosz Golaszewski , Mika Westerberg , Linus Walleij , Daniel Scally , Mark Gross , linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH v2 0/5] platform/x86: int3472: don't use gpiod_toggle_active_low() Message-ID: References: <20230926145943.42814-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 28, 2023 at 02:40:03PM +0200, Hans de Goede wrote: > Hi All, > > Here is a v2 of Bartosz' "don't use gpiod_toggle_active_low()" series. > > New in v2: > - Rework to deal with ACPI path vs gpiod_lookup.key differences: > acpi_get_handle(path) -> acpi_fetch_acpi_dev(handle) -> acpi_dev_name(adev) Code-wise LGTM, Reviewed-by: Andy Shevchenko But please fix tags here and there... -- With Best Regards, Andy Shevchenko