From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AB3CE784AF for ; Mon, 2 Oct 2023 09:46:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236245AbjJBJqy (ORCPT ); Mon, 2 Oct 2023 05:46:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236234AbjJBJqr (ORCPT ); Mon, 2 Oct 2023 05:46:47 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC20183; Mon, 2 Oct 2023 02:46:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696240004; x=1727776004; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+rojfav0AEhdlKxJ7yP2mhSeCWfVBVJaA5FY6zYujt8=; b=Ys05JtOXh1C35jRr4IwrZUmxSgRxWE2zjuMOGfNYwFfRWaXsN0Zfkkik lVfWA6r5qHs2c8L14IEtslhdjuuHzOJZ/620q4k4ZI57PHdLlbl1IQegE a/f3Z2lWu7Sc7HnvqeOsiJS5Yha09HRpFzPSC5Lo6poUIytfRPTIEBwrM azQMACN1ZCTPF8dS5Zg1fvSn9SCs4WdqGC5rkOLFS4Y9h4YM+a5YYDuAv oIeM3XIrQzDj1KolH4IVrKi/LRzs8LVJjcb31tKi0lwqaNUHbWtYf8MK6 rx+VjhSznhWsXzMSJGZFdvwS9grXgX6rUMjdFVrm0wu7Rz7eoMo6KsNx+ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10850"; a="372960262" X-IronPort-AV: E=Sophos;i="6.03,194,1694761200"; d="scan'208";a="372960262" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2023 02:46:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10850"; a="754005124" X-IronPort-AV: E=Sophos;i="6.03,194,1694761200"; d="scan'208";a="754005124" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga007.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2023 02:46:41 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC0) (envelope-from ) id 1qnFVf-000000027gX-048L; Mon, 02 Oct 2023 12:46:39 +0300 Date: Mon, 2 Oct 2023 12:46:38 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Linus Walleij , Mika Westerberg , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH v4 05/11] gpiolib: provide gpio_device_get_desc() Message-ID: References: <20230927142931.19798-1-brgl@bgdev.pl> <20230927142931.19798-6-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230927142931.19798-6-brgl@bgdev.pl> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 27, 2023 at 04:29:25PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Getting the GPIO descriptor directly from the gpio_chip struct is > dangerous as we don't take the reference to the underlying GPIO device. > In order to start working towards removing gpiochip_get_desc(), let's > provide a safer variant that works with an existing reference to struct > gpio_device. ... > +EXPORT_SYMBOL_GPL(gpiochip_get_desc); > +struct gpio_desc * > +gpio_device_get_desc(struct gpio_device *gdev, unsigned int hwnum) I'm wondering if you move this to be upper than gpiochip_get_desc() and diff will look better... -- With Best Regards, Andy Shevchenko