From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C22DDE784AF for ; Mon, 2 Oct 2023 09:57:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236329AbjJBJ53 (ORCPT ); Mon, 2 Oct 2023 05:57:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236322AbjJBJ5Z (ORCPT ); Mon, 2 Oct 2023 05:57:25 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA072E0; Mon, 2 Oct 2023 02:57:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696240640; x=1727776640; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=xkucgrf0Gku3sclZsNEmC/t2jO0YvL8B44d22Q1fSaQ=; b=mxhO8IHSTy4K6vDuEiB3qBkUavbLXi5VXnkwtEgxMzXoRPB4sUMe2TQG nEXqrvvPcb4gqahuA3UKqyS7+R5CztabmA91/lAcWL4ARkzqggZ/dDy2o 823/5psLEDILq5NItKj4bNsu8cbUC7/d+bLfRZlQiIK9GY+UdGHqETUSe E889RxCfoezNuuWZUVfuYUPDJTfOX9V/obPc86sQBPB0UJUVBFZ8cnPXB Z1Upx54m4dKKbcc8oj6E8y9Wh+S6nAEMC34PcPe6dvG3dDBUVbFZDQNwZ 0taBdXjoYrF7D8faxnL5uQhx1kj0WlPK+mUFzX0XjR6drZ9L62mNc93Ve w==; X-IronPort-AV: E=McAfee;i="6600,9927,10850"; a="372961768" X-IronPort-AV: E=Sophos;i="6.03,194,1694761200"; d="scan'208";a="372961768" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2023 02:57:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10850"; a="924221103" X-IronPort-AV: E=Sophos;i="6.03,194,1694761200"; d="scan'208";a="924221103" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2023 02:57:18 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC0) (envelope-from ) id 1qnFfv-000000027od-18zE; Mon, 02 Oct 2023 12:57:15 +0300 Date: Mon, 2 Oct 2023 12:57:14 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Linus Walleij , Mika Westerberg , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH v4 03/11] gpiolib: provide gpio_device_find() Message-ID: References: <20230927142931.19798-1-brgl@bgdev.pl> <20230927142931.19798-4-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 02, 2023 at 11:52:52AM +0200, Bartosz Golaszewski wrote: > On Mon, Oct 2, 2023 at 11:42 AM Andy Shevchenko > wrote: > > On Wed, Sep 27, 2023 at 04:29:23PM +0200, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski ... > > > struct gpio_chip *gpiochip_find(void *data, > > > int (*match)(struct gpio_chip *gc, > > > > > +struct gpio_device *gpio_device_find(void *data, > > > + int (*match)(struct gpio_chip *gc, > > > + void *data)) > > > > Why not > > > > typedef int (*gpio_chip_match_fn)(struct gpio_chip *gc, void *data); > > Because gpiochip_find() will go away as soon as we convert all users. And gpio_device_find() does not. So, I didn't get this argument. -- With Best Regards, Andy Shevchenko