From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA009E75437 for ; Tue, 3 Oct 2023 08:40:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238001AbjJCIkf (ORCPT ); Tue, 3 Oct 2023 04:40:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230259AbjJCIkd (ORCPT ); Tue, 3 Oct 2023 04:40:33 -0400 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D46D9A3; Tue, 3 Oct 2023 01:40:29 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 2FBB660005; Tue, 3 Oct 2023 08:40:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1696322428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YD9yrtCBZymzxDesfTQGfoyNHVBYtaajgX0MUzZwAM4=; b=it9nvDErLS3Dkumv3tt0+U8MyhdevvVnbQwCziN4asSKSbyARA7h9PvLo2sfSHeQ6e5jnb JyeqldpAwATrCmH2XtT9x8Uw3Kn+BtEvm96fyJkzGiTW/dj/1eeamkmoliQ0dLQcNsp9Cr tC5Jj9xnsOUIYT1LC0IlFPyGpWbUXbncdlz2ve6LVYaAWeKEFaSJ1J1fpJHRSmMie8N2C5 peoKR0TaXLkVUFr6dYTvhoEAReeN2XF9TrNgVavMYJcRI9yj8lskfA4XGUssgqclYZoHzi WOkyfGmE4MfbaGOXlwkNmtNL2iCsou3zL9/P1oQ4sDqQMQb/tvQiK4/TcmOv2w== Date: Tue, 3 Oct 2023 10:40:22 +0200 From: Mehdi Djait To: Rob Herring Cc: mchehab@kernel.org, heiko@sntech.de, ezequiel@vanguardiasur.com.ar, hverkuil-cisco@xs4all.nl, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, paul.kocialkowski@bootlin.com, miquel.raynal@bootlin.com, maxime.chevallier@bootlin.com, luca.ceresoli@bootlin.com, thomas.petazzoni@bootlin.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 1/3] media: dt-bindings: media: add rockchip-vip Message-ID: References: <6fa90df50c201dec70165c5138bc837f5a8829b5.1695981374.git.mehdi.djait@bootlin.com> <20231002171801.GA1942512-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231002171801.GA1942512-robh@kernel.org> X-GND-Sasl: mehdi.djait@bootlin.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Rob, Thank you for the review! On Mon, Oct 02, 2023 at 12:18:01PM -0500, Rob Herring wrote: > On Fri, Sep 29, 2023 at 12:08:00PM +0200, Mehdi Djait wrote: > > Add a documentation for the Rockchip Camera Interface controller > > binding. > > > > This controller can be found on platforms such as the PX30 or > > RK1808, RK3128 and RK3288. The PX30 is the only platform > > supported so far. > > > > Signed-off-by: Mehdi Djait > > --- > > .../bindings/media/rockchip-vip.yaml | 91 +++++++++++++++++++ > > filename should match compatible. > > > 1 file changed, 91 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/rockchip-vip.yaml > > > > diff --git a/Documentation/devicetree/bindings/media/rockchip-vip.yaml b/Documentation/devicetree/bindings/media/rockchip-vip.yaml > > new file mode 100644 > > index 000000000000..33c603209c39 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/rockchip-vip.yaml > > @@ -0,0 +1,91 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/media/rockchip-vip.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Rockchip VIP Camera Interface > > + > > +maintainers: > > + - Mehdi Djait > > + > > +description: |- > > Don't need '|-'. > > > + Rockchip Video Input Processor present on PX30, RK1808, RK3128 and RK3288 > > Write complete sentences. > > > > > + > > +properties: > > + compatible: > > + const: rockchip,px30-vip > > I see 4 SoCs listed, but only 1 compatible. > PX30 is the only SoC I have used to test the driver. What is the best way to proceed here ? Change the description ? ack for all the other comments. -- Kind Regards Mehdi Djait