From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D07A8E7AD7A for ; Tue, 3 Oct 2023 17:15:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231985AbjJCRP7 (ORCPT ); Tue, 3 Oct 2023 13:15:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231791AbjJCRP5 (ORCPT ); Tue, 3 Oct 2023 13:15:57 -0400 Received: from mail-yw1-x112a.google.com (mail-yw1-x112a.google.com [IPv6:2607:f8b0:4864:20::112a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0B81A3 for ; Tue, 3 Oct 2023 10:15:53 -0700 (PDT) Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-59f6441215dso14205937b3.2 for ; Tue, 03 Oct 2023 10:15:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696353353; x=1696958153; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zwjXmyJg//4md64VO14v8NSw+0L9l5ReENJrqoBIryA=; b=OeZp6aNpNJW/Y4qHKxirz7yprJ3O18nFEdfu2QnxXlmwIpHmZVOB//5Yi0oZrM6ccQ pgCkINfvqQSsKZgsCAKG9NsK305NeH4Kls3srR1pqrhAzZog3hPycjV/2+VKJ1OzfIXM AdTJJVleG+u8n4y+hpAYEv4jV+8TOiizaJZODkjiUD5aHb3kV+a/YVbVM70Yqrtvu3Mk ySubD3MSU7X+f2RPVgNvfaekLsVoWuLqjWjAxn0ZkR5KUBYTxGteT4fxaG7gvj20tZgt XLw+vf3edGh3QNudI12A55USpDxeZHMwc6Ma6GLm1n23XXanRjw14skFZcYm1lAM6m1W M6Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696353353; x=1696958153; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zwjXmyJg//4md64VO14v8NSw+0L9l5ReENJrqoBIryA=; b=ofHZOFq6KbJenpEP+U8+8ccONAB7l1rJRdJdJzCsPPi7smAUJL7tXmz974sM/L/xog gG/u7BxS1gJH9ORbZiADzXJQECYVc7orm+r1IXT8Blm4jKAV3PBnIScTuqr00mXL2SHs E1HJod2DNNiqxIKvuOGQxJbxc+Dy3Ouhyd7/Li/y3LAocU2EacthNWC/64Zj41ixL+lq HV69voFqGrFy+jZni4gjjO+IBvzkCG21q5VzCKv/PXh3ZD5blcwbh9jNBRe5btrwOjWx jg+P5UxU+AZqgWUbeR4jAcKwdgzNMDipAb7gW414r0zzLnKsWr5IY0avuzLQE2hJ6/DQ JcNw== X-Gm-Message-State: AOJu0YzRBedkMbyReCOiUtes+TJX9zw8SCn13m2vwW90ghm+Z7+BKj5+ 8STySV8ciWQidLWCkLLMg8I= X-Google-Smtp-Source: AGHT+IHOjK56X6tL4f3m6KC5uFzsBWiBTe8Av+5Q0zR4i4RfJz4JRMYVJ5L1ZmqRc/cvApRy4U+ULg== X-Received: by 2002:a0d:cace:0:b0:58c:4e63:109 with SMTP id m197-20020a0dcace000000b0058c4e630109mr296707ywd.0.1696353353020; Tue, 03 Oct 2023 10:15:53 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.gmail.com with ESMTPSA id r137-20020a0de88f000000b005a23a62a25csm515946ywe.9.2023.10.03.10.15.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 10:15:52 -0700 (PDT) Date: Tue, 3 Oct 2023 10:15:50 -0700 From: Vishal Moola To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Mike Kravetz , Muchun Song , Suren Baghdasaryan Subject: Re: [PATCH v1 1/3] mm/rmap: move SetPageAnonExclusive() out of page_move_anon_rmap() Message-ID: References: <20231002142949.235104-1-david@redhat.com> <20231002142949.235104-2-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231002142949.235104-2-david@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 02, 2023 at 04:29:47PM +0200, David Hildenbrand wrote: > Let's move it into the caller: there is a difference between whether an > anon folio can only be mapped by one process (e.g., into one VMA), and > whether it is truly exclusive (e.g., no references -- including GUP -- > from other processes). > > Further, for large folios the page might not actually be pointing at the > head page of the folio, so it better be handled in the caller. This is a > preparation for converting page_move_anon_rmap() to consume a folio. Reviewed-by: Vishal Moola (Oracle)