From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47DE2CDB482 for ; Wed, 18 Oct 2023 09:36:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229747AbjJRJgt (ORCPT ); Wed, 18 Oct 2023 05:36:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229753AbjJRJgm (ORCPT ); Wed, 18 Oct 2023 05:36:42 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B0129D for ; Wed, 18 Oct 2023 02:36:39 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82AC6C433C7; Wed, 18 Oct 2023 09:36:37 +0000 (UTC) Date: Wed, 18 Oct 2023 10:36:35 +0100 From: Catalin Marinas To: Ryan Roberts Cc: kernel test robot , Will Deacon , Steven Price , Peter Collingbourne , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64/mm: Hoist synchronization out of set_ptes() loop Message-ID: References: <20231005140730.2191134-1-ryan.roberts@arm.com> <202310140531.BQQwt3NQ-lkp@intel.com> <1634d3e0-ac13-4f08-97e3-9b04a9202431@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1634d3e0-ac13-4f08-97e3-9b04a9202431@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 18, 2023 at 09:21:02AM +0100, Ryan Roberts wrote: > On 17/10/2023 13:57, Catalin Marinas wrote: > > On Tue, Oct 17, 2023 at 08:36:43AM +0100, Ryan Roberts wrote: > >> On 16/10/2023 18:54, Catalin Marinas wrote: > >>> On Sat, Oct 14, 2023 at 05:15:51AM +0800, kernel test robot wrote: > >>>> kernel test robot noticed the following build warnings: > >>>> > >>>> [auto build test WARNING on arm64/for-next/core] > >>>> [also build test WARNING on arm-perf/for-next/perf arm/for-next kvmarm/next soc/for-next linus/master v6.6-rc5 next-20231013] > >>>> [cannot apply to arm/fixes] > >>>> [If your patch is applied to the wrong git tree, kindly drop us a note. > >>>> And when submitting patch, we suggest to use '--base' as documented in > >>>> https://git-scm.com/docs/git-format-patch#_base_tree_information] > >>>> > >>>> url: https://github.com/intel-lab-lkp/linux/commits/Ryan-Roberts/arm64-mm-Hoist-synchronization-out-of-set_ptes-loop/20231005-231636 > >>>> base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core > >>>> patch link: https://lore.kernel.org/r/20231005140730.2191134-1-ryan.roberts%40arm.com > >>>> patch subject: [PATCH v2] arm64/mm: Hoist synchronization out of set_ptes() loop > >>>> config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20231014/202310140531.BQQwt3NQ-lkp@intel.com/config) > >>>> compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a) > >>>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231014/202310140531.BQQwt3NQ-lkp@intel.com/reproduce) > >>>> > >>>> If you fix the issue in a separate patch/commit (i.e. not just a new version of > >>>> the same patch/commit), kindly add following tags > >>>> | Reported-by: kernel test robot > >>>> | Closes: https://lore.kernel.org/oe-kbuild-all/202310140531.BQQwt3NQ-lkp@intel.com/ > >>>> > >>>> All warnings (new ones prefixed by >>): > >>>> > >>>> In file included from net/ipv4/route.c:66: > >>>> In file included from include/linux/mm.h:29: > >>>> In file included from include/linux/pgtable.h:6: > >>>>>> arch/arm64/include/asm/pgtable.h:344:65: warning: parameter 'addr' set but not used [-Wunused-but-set-parameter] > >>>> 344 | static inline void set_ptes(struct mm_struct *mm, unsigned long addr, > >>>> | ^ > >>>> 1 warning generated. > >>> > >>> Thanks for the report. I think something like below will do (I'll test > >>> and commit as a separate patch, it's not something that Ryan's patch > >>> introduces): > >> > >> I was actually just trying to repro this and was planning to send out a v3 of my > >> patch. But if you are happy to handle it as you suggest, then I guess you don't > >> need anything further from me? > > > > If you feel like testing, please give this a go ;) > > Compile tested and observed that warning is gone with your change. Also ran mm > selftests and all looks good. So: > > Tested-by: Ryan Roberts Thanks. I'll push this patch on top of yours. -- Catalin