mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy@kernel.org>
To: Kartik <kkartik@nvidia.com>
Cc: thierry.reding@gmail.com, jonathanh@nvidia.com,
	keescook@chromium.org, akpm@linux-foundation.org, arnd@arndb.de,
	ulf.hansson@linaro.org, linus.walleij@linaro.org,
	pshete@nvidia.com, petlozup@nvidia.com, frank.li@vivo.com,
	robh@kernel.org, stefank@nvidia.com, pdeschrijver@nvidia.com,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v6 7/8] soc/tegra: fuse: Add ACPI support for Tegra194 and Tegra234
Date: Mon, 16 Oct 2023 15:42:28 +0300	[thread overview]
Message-ID: <ZS0vtOwDVwSMErK4@smile.fi.intel.com> (raw)
In-Reply-To: <20231016101436.7146-8-kkartik@nvidia.com>

On Mon, Oct 16, 2023 at 03:44:35PM +0530, Kartik wrote:
> Add ACPI support for Tegra194 & Tegra243 SoC's. This requires
> following modifications to the probe when ACPI boot is used:
>  - Initialize soc data.
>  - Add nvmem lookups.
>  - Register soc device.
>  - use devm_clk_get_optional() instead of devm_clk_get() to get
>    fuse->clk, as fuse clocks are not required when using ACPI boot.
> 
> Also, drop '__init' keyword for tegra_soc_device_register() as this is also
> used by tegra_fuse_probe() and use dev_err_probe() wherever applicable.

...

> +static const struct acpi_device_id __maybe_unused tegra_fuse_acpi_match[] = {

Drop __maybe_unused along with ACPI_PTR(), they are more confusing than helpful.

> +	{ "NVDA200F" },
> +	{ /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(acpi, tegra_fuse_acpi_match);
> +
>  static struct platform_driver tegra_fuse_driver = {
>  	.driver = {
>  		.name = "tegra-fuse",
>  		.of_match_table = tegra_fuse_match,
> +		.acpi_match_table = ACPI_PTR(tegra_fuse_acpi_match),
>  		.pm = &tegra_fuse_pm,
>  		.suppress_bind_attrs = true,
>  	},

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2023-10-16 12:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-16 10:14 [PATCH v6 0/8] soc/tegra: fuse: Add ACPI support Kartik
2023-10-16 10:14 ` [PATCH v6 1/8] mm/util: Introduce kmemdup_array() Kartik
2023-10-16 10:14 ` [PATCH v6 2/8] soc/tegra: fuse: Use dev_err_probe for probe failures Kartik
2023-10-16 10:14 ` [PATCH v6 3/8] soc/tegra: fuse: Refactor resource mapping Kartik
2023-10-16 10:14 ` [PATCH v6 4/8] soc/tegra: fuse: Add tegra_acpi_init_apbmisc() Kartik
2023-10-16 10:14 ` [PATCH v6 5/8] soc/tegra: fuse: Add function to add lookups Kartik
2023-10-16 10:14 ` [PATCH v6 6/8] soc/tegra: fuse: Add function to print SKU info Kartik
2023-10-16 10:14 ` [PATCH v6 7/8] soc/tegra: fuse: Add ACPI support for Tegra194 and Tegra234 Kartik
2023-10-16 12:42   ` Andy Shevchenko [this message]
2023-10-16 10:14 ` [PATCH v6 8/8] soc/tegra: fuse: Add support for Tegra241 Kartik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZS0vtOwDVwSMErK4@smile.fi.intel.com \
    --to=andy@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=frank.li@vivo.com \
    --cc=jonathanh@nvidia.com \
    --cc=keescook@chromium.org \
    --cc=kkartik@nvidia.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=pdeschrijver@nvidia.com \
    --cc=petlozup@nvidia.com \
    --cc=pshete@nvidia.com \
    --cc=robh@kernel.org \
    --cc=stefank@nvidia.com \
    --cc=thierry.reding@gmail.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome