From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F4100CDB465 for ; Mon, 16 Oct 2023 12:47:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233489AbjJPMrL (ORCPT ); Mon, 16 Oct 2023 08:47:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233480AbjJPMrI (ORCPT ); Mon, 16 Oct 2023 08:47:08 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65165ED for ; Mon, 16 Oct 2023 05:47:05 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-507a0907896so2659533e87.2 for ; Mon, 16 Oct 2023 05:47:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech-se.20230601.gappssmtp.com; s=20230601; t=1697460423; x=1698065223; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=6qlswPv1xYuo23Eivhw9YGnLAMdr4T3bJoXkm2ZqKu0=; b=wr+I54bx9Ul3ic/ReeHe5mldHrI7A7iwVEfn0BrrrqVf9xhsG3m1UgArv1KenBjPKB DfeRoINOFPOqsQUdmHoC4VuyRf3X/x61dxgtxqSoZIHuS5G7QyRgrX+GDbMRX+hMMyUy ASMkQZboTW1Uq+D2TSbkC1ykPEEpVZX/OBwOnfn4JUiOp9g35C0kx83AgqAgWlrB+D1J 3ofQH8ip4C3hMRxXlYa0NZvoA0HlcA4wAa+/w8VYWZLSbOzyoLy2B+MVF1WcaWRMhjr3 lJp3CPNTTnuJ9j5qiOB8ju25ibHmaRg1XdkE3Yu6a1hEQ8yhhJ8Bdxk5iL4tbbjaGGOG JVew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697460423; x=1698065223; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6qlswPv1xYuo23Eivhw9YGnLAMdr4T3bJoXkm2ZqKu0=; b=d1nWPrquv0+yEHjOOwWQ0JjY1FMBAcTyuYwdumaxQYzFpGxk+vqLJq0l1khysKpa+z WCMA6mCNgaZt6EWFqm0o9bOVcjrInHWQyIon9UpMEucUQG3pDXfD5mpfmE9aciiss/RF Qv0chpkkYvmCJ+Gc11g9ReBQxQt1fc94SsxsTKfcRMPr0nY/DmcoPBMpNXmTNXEY2+WC FzQuNnGSetjkAPRL51pfnLBJQuJ3JZh1tTjw0comIQbBTSHEoQ8tnU8/cUEgxwIrx0lF Yr5R5AURnoyMIE4ytHAL7L7CbLH9XcESKvNL9ZflnAu+N9Zl4WuY7VJ75Kyp2KYcAYBz gG/g== X-Gm-Message-State: AOJu0Yyghx7JC/CMXyZ9OvZlsY3+HPhT2XST1IdjNoue+fq/ln9E0fek HxaX8DxXBkBbh0C6aorhT55QQA== X-Google-Smtp-Source: AGHT+IEfwP8Ny2CwS5u9o3Y03kbQA8zl0t+JymNxTJZnFAbynfJOWtpPhq+AvNPWML0qNRbwl2S3YQ== X-Received: by 2002:a05:6512:282b:b0:505:7371:ec83 with SMTP id cf43-20020a056512282b00b005057371ec83mr33967223lfb.48.1697460423511; Mon, 16 Oct 2023 05:47:03 -0700 (PDT) Received: from localhost (h-46-59-36-206.A463.priv.bahnhof.se. [46.59.36.206]) by smtp.gmail.com with ESMTPSA id b4-20020a056512070400b00502e2ab7118sm734431lfs.50.2023.10.16.05.47.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 05:47:03 -0700 (PDT) Date: Mon, 16 Oct 2023 14:47:02 +0200 From: Niklas =?utf-8?Q?S=C3=B6derlund?= To: ihor.matushchak@foobox.net Cc: mchehab@kernel.org, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] media: staging: max96712: fix copy-paste error Message-ID: References: <20231015212447.7072-1-ihor.matushchak@foobox.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231015212447.7072-1-ihor.matushchak@foobox.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org HI Ihor, Thanks for your work. Maybe use a more descriptive commit title? The idea is to describe the issue a patch addresses in the title. Not the reason why the issue was introduced, this goes into the commit message. Imagine another copy-paste error is found in the driver, then we would have two commits with the same title. How about? 'media: staging: max96712: Fix device name in description' On 2023-10-15 22:24:47 +0100, ihor.matushchak@foobox.net wrote: > From: Ihor Matushchak > > Fix the device model name in driver description, > which appears to be a copy-paste error Super-nit: Missing trailing dot. > > Signed-off-by: Ihor Matushchak > --- > Changes in v2: > Add commit message describing the change; > > drivers/staging/media/max96712/max96712.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/max96712/max96712.c b/drivers/staging/media/max96712/max96712.c > index c44145284aa1..ea67bcf69c9d 100644 > --- a/drivers/staging/media/max96712/max96712.c > +++ b/drivers/staging/media/max96712/max96712.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > - * Maxim MAX9286 Quad GMSL2 Deserializer Driver > + * Maxim MAX96712 Quad GMSL2 Deserializer Driver > * > * Copyright (C) 2021 Renesas Electronics Corporation > * Copyright (C) 2021 Niklas Söderlund > -- > 2.30.2 > -- Kind Regards, Niklas Söderlund