From: Guillem Jover <guillem@hadrons.org>
To: Alejandro Colomar <alx@kernel.org>
Cc: Axel Rasmussen <axelrasmussen@google.com>,
Peter Xu <peterx@redhat.com>,
linux-man@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Mike Rapoport <rppt@kernel.org>
Subject: Re: [PATCH v2 4/5] ioctl_userfaultfd.2: fix / update UFFDIO_REGISTER error code list
Date: Tue, 17 Oct 2023 23:23:10 +0200 [thread overview]
Message-ID: <ZS77PhZA9q6zQw7_@thunder.hadrons.org> (raw)
In-Reply-To: <ZSMn-H_BUmJMi9La@debian>
Hi!
On Mon, 2023-10-09 at 00:06:48 +0200, Alejandro Colomar wrote:
> This produces some unwanted space. Please apply the following fix to
> your patch.
>
> diff --git a/man2/ioctl_userfaultfd.2 b/man2/ioctl_userfaultfd.2
> index 6e954e98c..795014794 100644
> --- a/man2/ioctl_userfaultfd.2
> +++ b/man2/ioctl_userfaultfd.2
> @@ -432,11 +432,11 @@ .SS UFFDIO_REGISTER
> no mapping exists in the given range,
> or the mapping that exists there is invalid
> (e.g. unsupported type of memory),
> -or the range values (
> -.I range.start
> +or the range values
> +.IR ( range.start
I think you meant «.RI» here?
> or
> -.I range.len
> -) are not multiples of the relevant page size,
> +.IR range.len )
> +are not multiples of the relevant page size,
> or
> .I range.len
> is zero.
>
Regards,
Guillem
next prev parent reply other threads:[~2023-10-17 21:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 19:45 [PATCH v2 0/5] userfaultfd man page updates Axel Rasmussen
2023-10-03 19:45 ` [PATCH v2 1/5] ioctl_userfaultfd.2: describe two-step feature handshake Axel Rasmussen
2023-10-08 22:23 ` Alejandro Colomar
2023-10-03 19:45 ` [PATCH v2 2/5] ioctl_userfaultfd.2: correct and update UFFDIO_API ioctl error codes Axel Rasmussen
2023-10-08 22:25 ` Alejandro Colomar
2023-10-03 19:45 ` [PATCH v2 3/5] ioctl_userfaultfd.2: clarify the state of the uffdio_api structure on error Axel Rasmussen
2023-10-08 21:52 ` Alejandro Colomar
2023-10-09 9:12 ` Mike Rapoport
2023-10-03 19:45 ` [PATCH v2 4/5] ioctl_userfaultfd.2: fix / update UFFDIO_REGISTER error code list Axel Rasmussen
2023-10-08 22:06 ` Alejandro Colomar
2023-10-17 21:23 ` Guillem Jover [this message]
2023-10-17 21:42 ` Alejandro Colomar
2023-10-17 22:14 ` Axel Rasmussen
2023-10-03 19:45 ` [PATCH v2 5/5] ioctl_userfaultfd.2: document new UFFDIO_POISON ioctl Axel Rasmussen
2023-10-08 22:23 ` Alejandro Colomar
2023-10-17 22:25 ` Axel Rasmussen
2023-10-08 22:27 ` [PATCH v2 0/5] userfaultfd man page updates Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZS77PhZA9q6zQw7_@thunder.hadrons.org \
--to=guillem@hadrons.org \
--cc=alx@kernel.org \
--cc=axelrasmussen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®