mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: acpi4asus-user@lists.sourceforge.net,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"João Paulo Rechi Vita" <jprvita@gmail.com>,
	"Corentin Chary" <corentin.chary@gmail.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Mark Gross" <markgross@kernel.org>
Subject: Re: [PATCH v3 1/1] platform/x86: asus-wireless: Replace open coded acpi_match_device()
Date: Sat, 7 Oct 2023 10:25:52 +0300	[thread overview]
Message-ID: <ZSEIAL4m9WbpJTW8@smile.fi.intel.com> (raw)
In-Reply-To: <371fc87d-ade3-51b8-6f56-4d99dad88873@redhat.com>

On Fri, Oct 06, 2023 at 07:08:35PM +0200, Hans de Goede wrote:
> On 10/6/23 17:53, Andy Shevchenko wrote:

...

> Thanks, patch looks good to me now:
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Thanks, but it seems something went wrong (most likely due to age of the
patches in my local tree) and confusing "BUILD SUCCESS" from LKP.

> > +	id = acpi_match_device(device_ids, adev);

This should be acpi_match_acpi_device().

> > +	if (!id)
> >  		return 0;

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2023-10-07  7:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-06 15:53 Andy Shevchenko
2023-10-06 17:08 ` Hans de Goede
2023-10-07  7:25   ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZSEIAL4m9WbpJTW8@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=acpi4asus-user@lists.sourceforge.net \
    --cc=corentin.chary@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jprvita@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markgross@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome