From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Mark Gross" <markgross@kernel.org>
Subject: Re: [PATCH v2 1/1] platform/x86: xo15-ebook: Replace open coded acpi_match_device()
Date: Sat, 7 Oct 2023 10:27:04 +0300 [thread overview]
Message-ID: <ZSEISNzKdNIs7WHy@smile.fi.intel.com> (raw)
In-Reply-To: <ff4e541d-590b-7eef-aeee-dc15ca869691@redhat.com>
On Fri, Oct 06, 2023 at 05:34:19PM +0200, Hans de Goede wrote:
> On 10/6/23 17:31, Andy Shevchenko wrote:
...
`
> Thanks, patch looks good to me:
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Same issue as with other patch...
...
> > + id = acpi_match_device(ebook_device_ids, device);
Should be acpi_match_acpi_device().
> > + if (!id) {
> > + dev_err(&device->dev, "Unsupported hid\n");
> > error = -ENODEV;
> > goto err_free_input;
> > }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-10-07 7:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 15:31 Andy Shevchenko
2023-10-06 15:34 ` Hans de Goede
2023-10-07 7:27 ` Andy Shevchenko [this message]
2023-10-06 18:57 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSEISNzKdNIs7WHy@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome