From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: RD Babiera <rdbabiera@google.com>
Cc: gregkh@linuxfoundation.org, badhri@google.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v1] usb: typec: altmodes/displayport: Signal hpd low when exiting mode
Date: Tue, 10 Oct 2023 11:44:02 +0300 [thread overview]
Message-ID: <ZSUO0rkmTsRkV361@kuha.fi.intel.com> (raw)
In-Reply-To: <20231009210057.3773877-2-rdbabiera@google.com>
On Mon, Oct 09, 2023 at 09:00:58PM +0000, RD Babiera wrote:
> Upon receiving an ACK for a sent EXIT_MODE message, the DisplayPort
> driver currently resets the status and configuration of the port partner.
> The hpd signal is not updated despite being part of the status, so the
> Display stack can still transmit video despite typec_altmode_exit placing
> the lanes in a Safe State.
>
> Set hpd to low when a sent EXIT_MODE message is ACK'ed.
>
> Fixes: 0e3bb7d6894d ("usb: typec: Add driver for DisplayPort alternate mode")
> Cc: stable@vger.kernel.org
> Signed-off-by: RD Babiera <rdbabiera@google.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/altmodes/displayport.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c
> index f503cb4cd721..718da02036d8 100644
> --- a/drivers/usb/typec/altmodes/displayport.c
> +++ b/drivers/usb/typec/altmodes/displayport.c
> @@ -307,6 +307,11 @@ static int dp_altmode_vdm(struct typec_altmode *alt,
> typec_altmode_update_active(alt, false);
> dp->data.status = 0;
> dp->data.conf = 0;
> + if (dp->hpd) {
> + drm_connector_oob_hotplug_event(dp->connector_fwnode);
> + dp->hpd = false;
> + sysfs_notify(&dp->alt->dev.kobj, "displayport", "hpd");
> + }
> break;
> case DP_CMD_STATUS_UPDATE:
> dp->data.status = *vdo;
>
> base-commit: 1053c4a4b8fcbd28386e80347e7c82d4d617e352
> --
> 2.42.0.609.gbb76f46606-goog
--
heikki
prev parent reply other threads:[~2023-10-10 8:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 21:00 RD Babiera
2023-10-10 8:44 ` Heikki Krogerus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSUO0rkmTsRkV361@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=badhri@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rdbabiera@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®