From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2305FCD68E5 for ; Tue, 10 Oct 2023 09:04:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229646AbjJJJEM (ORCPT ); Tue, 10 Oct 2023 05:04:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229531AbjJJJEL (ORCPT ); Tue, 10 Oct 2023 05:04:11 -0400 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB098A7; Tue, 10 Oct 2023 02:04:09 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1qq8eW-005TST-2G; Tue, 10 Oct 2023 17:03:45 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Tue, 10 Oct 2023 17:03:48 +0800 Date: Tue, 10 Oct 2023 17:03:48 +0800 From: Herbert Xu To: Cong Wang Cc: Ma Ke , steffen.klassert@secunet.com, davem@davemloft.net, dsahern@kernel.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ipv6: fix return value check in esp_remove_trailer Message-ID: References: <20231007005953.3994960-1-make_ruc2021@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 08, 2023 at 10:07:30AM -0700, Cong Wang wrote: > On Sat, Oct 07, 2023 at 08:59:53AM +0800, Ma Ke wrote: > > In esp_remove_trailer(), to avoid an unexpected result returned by > > pskb_trim, we should check the return value of pskb_trim(). > > > > Signed-off-by: Ma Ke > > --- > > net/ipv6/esp6.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > We need the same change for net/ipv4/esp4.c? Please verify that it can actually fail first. Note that I'm busy right now so I haven't looked at it at all. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt