From: Andy Shevchenko <andy@kernel.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/20] pinctrl: intel: lynxpoint: Convert to platform remove callback returning void
Date: Tue, 10 Oct 2023 16:18:52 +0300 [thread overview]
Message-ID: <ZSVPPJWGkGvx4ug0@smile.fi.intel.com> (raw)
In-Reply-To: <20231009111048.GF3208943@black.fi.intel.com>
On Mon, Oct 09, 2023 at 02:10:48PM +0300, Mika Westerberg wrote:
> On Mon, Oct 09, 2023 at 10:38:42AM +0200, Uwe Kleine-König wrote:
> > The .remove() callback for a platform driver returns an int which makes
> > many driver authors wrongly assume it's possible to do error handling by
> > returning an error code. However the value returned is ignored (apart
> > from emitting a warning) and this typically results in resource leaks.
> >
> > To improve here there is a quest to make the remove callback return
> > void. In the first step of this quest all drivers are converted to
> > .remove_new(), which already returns void. Eventually after all drivers
> > are converted, .remove_new() will be renamed to .remove().
> >
> > Trivially convert this driver from always returning zero in the remove
> > callback to the void returning variant.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Pushed to my review and testing queue, thanks!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-10-10 13:24 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 8:38 [PATCH 00/20] pinctrl: " Uwe Kleine-König
2023-10-09 8:38 ` [PATCH 01/20] pinctrl: stmfx: Improve error message in .remove()'s error path Uwe Kleine-König
2023-10-10 13:35 ` Linus Walleij
2023-10-09 8:38 ` [PATCH 02/20] pinctrl: single: Drop if block with always false condition Uwe Kleine-König
2023-10-10 13:36 ` Linus Walleij
2023-10-09 8:38 ` [PATCH 03/20] pinctrl: ti: ti-iodelay: " Uwe Kleine-König
2023-10-10 13:36 ` Linus Walleij
2023-10-09 8:38 ` [PATCH 04/20] pinctrl: cirrus: madera-core: Convert to platform remove callback returning void Uwe Kleine-König
2023-10-09 10:37 ` Charles Keepax
2023-10-10 13:37 ` Linus Walleij
2023-10-09 8:38 ` [PATCH 05/20] pinctrl: intel: cherryview: " Uwe Kleine-König
2023-10-09 11:10 ` Mika Westerberg
2023-10-10 13:18 ` Andy Shevchenko
2023-10-09 8:38 ` [PATCH 06/20] pinctrl: intel: lynxpoint: " Uwe Kleine-König
2023-10-09 11:10 ` Mika Westerberg
2023-10-10 13:18 ` Andy Shevchenko [this message]
2023-10-10 15:34 ` Andy Shevchenko
2023-10-09 8:38 ` [PATCH 07/20] pinctrl: nomadik: abx500: " Uwe Kleine-König
2023-10-10 13:38 ` Linus Walleij
2023-10-09 8:38 ` [PATCH 08/20] pinctrl: amd: " Uwe Kleine-König
2023-10-10 13:38 ` Linus Walleij
2023-10-09 8:38 ` [PATCH 09/20] pinctrl: artpec6: " Uwe Kleine-König
2023-10-10 8:40 ` Jesper Nilsson
2023-10-10 13:39 ` Linus Walleij
2023-10-09 8:38 ` [PATCH 10/20] pinctrl: as3722: " Uwe Kleine-König
2023-10-10 13:39 ` Linus Walleij
2023-10-09 8:38 ` [PATCH 11/20] pinctrl: rockchip: " Uwe Kleine-König
2023-10-09 20:16 ` Heiko Stuebner
2023-10-10 13:40 ` Linus Walleij
2023-10-09 8:38 ` [PATCH 12/20] pinctrl: single: " Uwe Kleine-König
2023-10-10 13:41 ` Linus Walleij
2023-10-09 8:38 ` [PATCH 13/20] pinctrl: stmfx: " Uwe Kleine-König
2023-10-10 13:41 ` Linus Walleij
2023-10-09 8:38 ` [PATCH 14/20] pinctrl: tb10x: " Uwe Kleine-König
2023-10-10 13:42 ` Linus Walleij
2023-10-09 8:38 ` [PATCH 15/20] pinctrl: qcom: spmi-gpio: " Uwe Kleine-König
2023-10-10 13:42 ` Linus Walleij
2023-10-09 8:38 ` [PATCH 16/20] pinctrl: qcom: spmi-mpp: " Uwe Kleine-König
2023-10-10 13:43 ` Linus Walleij
2023-10-09 8:38 ` [PATCH 17/20] pinctrl: qcom: ssbi-gpio: " Uwe Kleine-König
2023-10-10 13:43 ` Linus Walleij
2023-10-09 8:38 ` [PATCH 18/20] pinctrl: qcom: ssbi-mpp: " Uwe Kleine-König
2023-10-10 13:44 ` Linus Walleij
2023-10-09 8:38 ` [PATCH 19/20] pinctrl: renesas: rzn1: " Uwe Kleine-König
2023-10-09 9:39 ` Geert Uytterhoeven
2023-10-10 13:45 ` Linus Walleij
2023-10-10 13:48 ` Geert Uytterhoeven
2023-10-09 8:38 ` [PATCH 20/20] pinctrl: ti: ti-iodelay: " Uwe Kleine-König
2023-10-10 13:45 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSVPPJWGkGvx4ug0@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome