From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5878CDB46E for ; Thu, 12 Oct 2023 07:06:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343599AbjJLHGn (ORCPT ); Thu, 12 Oct 2023 03:06:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343567AbjJLHGm (ORCPT ); Thu, 12 Oct 2023 03:06:42 -0400 Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8855F90 for ; Thu, 12 Oct 2023 00:06:40 -0700 (PDT) Received: (from willy@localhost) by mail.home.local (8.17.1/8.17.1/Submit) id 39C76Xsb005111; Thu, 12 Oct 2023 09:06:33 +0200 Date: Thu, 12 Oct 2023 09:06:33 +0200 From: Willy Tarreau To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Zhangjin Wu , linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/nolibc: add tests for multi-object linkage Message-ID: References: <20231012-nolibc-linkage-test-v1-1-315e682768b4@weissschuh.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231012-nolibc-linkage-test-v1-1-315e682768b4@weissschuh.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Thomas, On Thu, Oct 12, 2023 at 01:13:37AM +0200, Thomas Weißschuh wrote: > While uncommon, nolibc executables can be linked together from multiple > compilation units. > Add some tests to make sure everything works in that case. (...) Glad you did these two. Your approach is good and it remains easy to use and should catch next breakage in this area. > Signed-off-by: Thomas Weißschuh > --- > Note: > > This depends on path "tools/nolibc: mark start_c as weak". > https://lore.kernel.org/lkml/20231012-nolibc-start_c-multiple-v1-1-fbfc73e0283f@weissschuh.net/ For these two patches: Acked-by: Willy Tarreau Thanks Willy