From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E05FCDB46E for ; Thu, 12 Oct 2023 13:55:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378984AbjJLNzO (ORCPT ); Thu, 12 Oct 2023 09:55:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233194AbjJLNzM (ORCPT ); Thu, 12 Oct 2023 09:55:12 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5689691; Thu, 12 Oct 2023 06:55:11 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-5384975e34cso1920615a12.0; Thu, 12 Oct 2023 06:55:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697118910; x=1697723710; darn=vger.kernel.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Fu8VOT2Hnt8xZp2XbOVoQ85nqe18SW0MJ+Lu2qeF2EE=; b=kSa4UhHPZXPWVfLnPt7vIeVI4rIz7hsokcU+vxL4wA1nnlo9K+HgMNJcDHw2UPV1I9 ju7HeeqKCTsDtz8M0KaskJzTi+YCCQ7W5C0lqRqLwStlMuKeZD1ntQU/s9Cvudrt45zh sUKeB/kZUceKfZLjIuG6gLSpMYN6S8Lv61SlYPXsH6qDYwOFx3KLkFcs3ABJSQzN9a6X zSgNGDB+jMvevoJbnVMhUGhG7eEMIUzkcOmCh4OaiHc1aKr94TYXWsFnZAWjVq+U24vI AAGgMqI+RdbMj/lEjQtg32H1Ec3Mh4oHoiX6VZrZnndqz/+DteiS9EK8YW46W1r/CvjV pvmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697118910; x=1697723710; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Fu8VOT2Hnt8xZp2XbOVoQ85nqe18SW0MJ+Lu2qeF2EE=; b=VUY57f7WArh81WWyh0CCKkOZvjS2zcRalss8DN+mg0iBCW/drZ9sgpO2fZT/1z9tBn eEZICAjT0lWfgiPdLuuNFtjkQz/qzNm65L8Fw47zSVePH/9IYtDft8ubXILneRp88FzU R/JmKC3onnru5LES7n4shOc43aHw/4bXM2aLHAWme3fhXKbVCRv4qAFawiTYwdgY0GoU iSWbvoUqz4n0IJ+8mtPJ2F1pxPmaPZOaHGxB1cQsMd6HGfm9Qm5dfpcWW7B9z+6JH7xb wo87tuKBeCedqjmqadNHaYrYDZxDZqmexNOBt+c5yOGUY17XRc2RL3FnxOhkUu468w7m Y1ug== X-Gm-Message-State: AOJu0YzI1m5Kq+AIFmZLyJqAfkxVo8gjkLv6IYcB4RNohFkyVY6IAqSj +005/xLC4+lgVNUpZuGjg9E= X-Google-Smtp-Source: AGHT+IGFL/GdmvGinRbRH7PZlZJVM+sNoLaueLqYAs31lFSe24A12+nl+91t4XdlRciydU++p+bA/w== X-Received: by 2002:a05:6402:1cb1:b0:53b:3225:93c2 with SMTP id cz17-20020a0564021cb100b0053b322593c2mr14950542edb.8.1697118909629; Thu, 12 Oct 2023 06:55:09 -0700 (PDT) Received: from orome.fritz.box (p200300e41f3f4900f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f3f:4900:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id cw2-20020a056402228200b0053dea07b669sm1783014edb.87.2023.10.12.06.55.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Oct 2023 06:55:09 -0700 (PDT) Date: Thu, 12 Oct 2023 15:55:07 +0200 From: Thierry Reding To: Florian Fainelli Cc: linux-pwm@vger.kernel.org, Angus Clark , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Ray Jui , Scott Branden , Broadcom internal kernel review list , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v3] pwm: bcm2835: Add support for suspend/resume Message-ID: References: <20231011170717.3738712-1-florian.fainelli@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20231011170717.3738712-1-florian.fainelli@broadcom.com> User-Agent: Mutt/2.2.12 (2023-09-09) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 11, 2023 at 10:07:17AM -0700, Florian Fainelli wrote: > Similar to other drivers, we need to make sure that the clock is > disabled during suspend and re-enabled during resume. >=20 > Reported-by: Angus Clark > Signed-off-by: Florian Fainelli > --- > Changes in v3: >=20 > - removed __maybe_unused and use pm_ptr() >=20 > Changes in v2: >=20 > - use DEFINE_SIMPLE_DEV_PM_OPS as suggested by Uwe >=20 > drivers/pwm/pwm-bcm2835.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) Applied, thanks. Thierry