From: Steffen Klassert <steffen.klassert@secunet.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
Ma Ke <make_ruc2021@163.com>, <davem@davemloft.net>,
<dsahern@kernel.org>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: ipv6: fix return value check in esp_remove_trailer
Date: Fri, 13 Oct 2023 07:53:46 +0200 [thread overview]
Message-ID: <ZSjbatU0tcVZGWCW@gauss3.secunet.de> (raw)
In-Reply-To: <ZSUTdBpSTgNz5CA8@gondor.apana.org.au>
On Tue, Oct 10, 2023 at 05:03:48PM +0800, Herbert Xu wrote:
> On Sun, Oct 08, 2023 at 10:07:30AM -0700, Cong Wang wrote:
> > On Sat, Oct 07, 2023 at 08:59:53AM +0800, Ma Ke wrote:
> > > In esp_remove_trailer(), to avoid an unexpected result returned by
> > > pskb_trim, we should check the return value of pskb_trim().
> > >
> > > Signed-off-by: Ma Ke <make_ruc2021@163.com>
> > > ---
> > > net/ipv6/esp6.c | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > We need the same change for net/ipv4/esp4.c?
>
> Please verify that it can actually fail first. Note that I'm
> busy right now so I haven't looked at it at all.
It can, we don't linearize the packte data anymore.
next prev parent reply other threads:[~2023-10-13 5:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-07 0:59 Ma Ke
2023-10-08 17:07 ` Cong Wang
2023-10-10 9:03 ` Herbert Xu
2023-10-13 5:53 ` Steffen Klassert [this message]
2023-10-13 5:55 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSjbatU0tcVZGWCW@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=make_ruc2021@163.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®