From: Herbert Xu <herbert@gondor.apana.org.au>
To: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] crypto: remove md4 driver
Date: Fri, 13 Oct 2023 18:39:20 +0800 [thread overview]
Message-ID: <ZSkeWHdOAOfjtpwJ@gondor.apana.org.au> (raw)
In-Reply-To: <20231008040140.1647892-1-dimitri.ledkov@canonical.com>
On Sun, Oct 08, 2023 at 05:01:39AM +0100, Dimitri John Ledkov wrote:
> No internal users left and cryptographically insecure. Users should
> upgrade to something else, e.g. sha256 blake3.
>
> Some drivers have their own full or partial md4 implementation without
> using crypto/md4.
>
> Userspace code search indicates a few copies of hash_info.h
> https://codesearch.debian.net/search?q=HASH_ALGO_MD4&literal=1 without
> need for MD4.
>
> Preserve uapi hash algorithm indexes and array length, but rename the
> MD4 enum.
>
> Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
> ---
> crypto/Kconfig | 6 -
> crypto/Makefile | 1 -
> crypto/hash_info.c | 4 +-
> crypto/md4.c | 241 ---------------------------------
> crypto/tcrypt.c | 12 --
> crypto/testmgr.c | 6 -
> crypto/testmgr.h | 42 ------
> include/uapi/linux/hash_info.h | 2 +-
> 8 files changed, 3 insertions(+), 311 deletions(-)
> delete mode 100644 crypto/md4.c
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2023-10-13 10:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-08 4:01 Dimitri John Ledkov
2023-10-13 10:39 ` Herbert Xu [this message]
2023-10-13 14:37 ` Denis Kenzior
2023-10-13 14:39 ` Dimitri John Ledkov
2023-10-14 4:06 ` Herbert Xu
2023-10-14 23:02 ` Dimitri John Ledkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSkeWHdOAOfjtpwJ@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=dimitri.ledkov@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®