mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>
Cc: "Stoll, Eberhard" <eberhard.stoll@kontron.de>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Eberhard Stoll" <estl@gmx.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
	"Schrempf, Frieder" <frieder.schrempf@kontron.de>,
	"Amit Kumar Mahapatra" <amit.kumar-mahapatra@amd.com>,
	"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Krishna Yarlagadda" <kyarlagadda@nvidia.com>,
	"Leonard Göhrs" <l.goehrs@pengutronix.de>,
	"Yang Yingliang" <yangyingliang@huawei.com>
Subject: Re: AW: [PATCH 1/4] spi: Add parameter for clock to rx delay
Date: Mon, 30 Oct 2023 10:48:08 +0200	[thread overview]
Message-ID: <ZT9tyDEBqwqv26O8@smile.fi.intel.com> (raw)
In-Reply-To: <ZTvbFc+kFMotVUkh@finisterre.sirena.org.uk>

On Fri, Oct 27, 2023 at 04:45:25PM +0100, Mark Brown wrote:
> On Fri, Oct 27, 2023 at 02:46:42PM +0300, Andy Shevchenko wrote:
> 
> > So, to me sounds like device tree source issue. I.e. you need to provide
> > different DT(b)s depending on the platform (and how it should be).
> > The cleanest solution (as I see not the first time people I trying quirks like
> > this to be part of the subsystems / drivers) is to make DT core (OF) to have
> > conditionals or boot-time modifications allowed.
> 
> > This, what you are doing, does not scale and smells like an ugly hack.
> 
> No, this seems like an entirely reasonable thing to have - it's just a
> property of the device, we don't need to add a DT property for it, and
> the maximum speed that the device can run at is going to vary depending
> on the ability of the controller to control the sampling point.
> 
> As people have been saying there's a particularly clear case for this
> with SPI flash which is probed at runtime and is readily substituted at
> the hardware level.

So, then the question is what does DT _actually_ describes?
If we have an autoprobe of something that doesn't work on platform A and works
on platform B, shouldn't these platforms have to have distinguishable DTs?

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2023-10-30  8:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-26 15:23 [PATCH 0/4] Add tCLQV parameter to tweak SPI timings Eberhard Stoll
2023-10-26 15:23 ` [PATCH 1/4] spi: Add parameter for clock to rx delay Eberhard Stoll
2023-10-26 22:56   ` Miquel Raynal
2023-10-27  8:38     ` AW: " Stoll, Eberhard
2023-10-27 11:46       ` Andy Shevchenko
     [not found]         ` <ZTvbFc+kFMotVUkh@finisterre.sirena.org.uk>
2023-10-30  8:48           ` Andy Shevchenko [this message]
2023-10-30  9:28             ` AW: " Stoll, Eberhard
2023-10-26 15:23 ` [PATCH 2/4] mtd: spinand: Add support for clock to rx delay setting Eberhard Stoll
2023-10-26 15:23 ` [PATCH 3/4] mtd: spinand: winbond: Add rx sample delay for W25N02KV Eberhard Stoll
2023-10-26 15:23 ` [PATCH 4/4] spi: spi-fsl-qspi: Add support for rx data sample point adjustment Eberhard Stoll
2023-10-26 20:03   ` kernel test robot
2023-10-27  6:51     ` Frieder Schrempf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZT9tyDEBqwqv26O8@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=amit.kumar-mahapatra@amd.com \
    --cc=broonie@kernel.org \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=eberhard.stoll@kontron.de \
    --cc=estl@gmx.net \
    --cc=frieder.schrempf@kontron.de \
    --cc=frowand.list@gmail.com \
    --cc=geert+renesas@glider.be \
    --cc=kyarlagadda@nvidia.com \
    --cc=l.goehrs@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=robh+dt@kernel.org \
    --cc=yangyingliang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®