From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95DABCDB47E for ; Wed, 18 Oct 2023 18:26:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231506AbjJRS0B (ORCPT ); Wed, 18 Oct 2023 14:26:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230296AbjJRS0A (ORCPT ); Wed, 18 Oct 2023 14:26:00 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 932B7B6; Wed, 18 Oct 2023 11:25:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=99zA8o13/ejaEM2O9/K0kn45FaKKMRK+h1KEU8ji9+A=; b=V5phy8EHYfhtPfVyyG8Exv3G/r Pw9Vvflf4+xBXK/uMwG2DGE/qdGXwm9pcyW6dJo/OOocmhxsI9aB14b3THWJ5W1/ENsEgMQCTzTY9 GArQsjXE+6rZK3EK6yo6y1moCF//BhGc72niOCUs2iMiRgRfcF9IGyKstZ+u/zQqjS+RcTwAJXFXy iuhdOEie6GRBdLNWbiXAgStwO1jb6aHU7oGZeXrBUqhvyXbAaLTrEj18N40UvgmycR39epxmr0CNh FZpRc55o2s6iaf3eR6T4bk/5j3m70Vbr3urwfCedbJ8nVpBqAg+9FJanWPIwETux/tFacgUggpkYr Dna5ig9A==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qtBEp-00FReC-07; Wed, 18 Oct 2023 18:25:47 +0000 Date: Wed, 18 Oct 2023 11:25:46 -0700 From: Luis Chamberlain To: Christoph Hellwig Cc: David Woodhouse , Greg Kroah-Hartman , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Ulf Hansson , Manuel Lauss , Yangbo Lu , Joshua Kinard , Daniel Vetter , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, open list , linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org, linux-modules@vger.kernel.org Subject: Re: [PATCH 5/5] modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules Message-ID: References: <20230801173544.1929519-1-hch@lst.de> <20230801173544.1929519-6-hch@lst.de> <20231018053146.GA16765@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231018053146.GA16765@lst.de> Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 18, 2023 at 07:31:46AM +0200, Christoph Hellwig wrote: > On Wed, Oct 18, 2023 at 01:30:18AM +0100, David Woodhouse wrote: > > > > But if we're going to tolerate the core kernel still exporting some > > stuff with EXPORT_SYMBOL, why isn't OK for a GPL-licensed module do to > > the same? Even an *in-tree* GPL-licensed module now can't export > > functionality with EXPORT_SYMBOL and have it used with symbol_get(). > > Anything using symbol_get is by intent very deeply internal for tightly > coupled modules working together, and thus not a non-GPL export. > > In fact the current series is just a stepping stone. Once some mess > in the kvm/vfio integration is fixed up we'll require a new explicit > EXPORT_SYMBOL variant as symbol_get wasn't ever intended to be used > on totally random symbols not exported for use by symbol_get. The later patches in the series also show we could resolves most uses through Kconfig and at build time, it really begs the question if we even need it for any real valid uses. Luis