From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E015CDB484 for ; Thu, 19 Oct 2023 15:41:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346456AbjJSPli (ORCPT ); Thu, 19 Oct 2023 11:41:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346415AbjJSPle (ORCPT ); Thu, 19 Oct 2023 11:41:34 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A46F0CF for ; Thu, 19 Oct 2023 08:41:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697730091; x=1729266091; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=CDx3gZhvxaM5/jmqnpt21Zm3HDhkPDg+Lf+cMLXSiOI=; b=hU+WJi0ZU30L27GbJH9CcP2ww/hp+NV2vZ95o1PvOtLiTzThYd+5YZ07 22CcAach4eyKIoLYO+f9q3sLe7yHO91rrpiT8aka7HUIiItaZ+p0V5ENy N6+w4zVZdZ0sFFYtpjQZNPI3fuTIrZgzyvAC+odX1+njnP26rmY8+OBtr K7tCdeotaDInU4DMX4AmCmUMhhA3ZuCGkRiImf03JOJ9TzKh0/Z+zbyW3 mpjKuIfHkTOsJyIfxbSbOvBCctW3kM9KQ+Vd5TXVlwsVz0Tg6d0+kdfzn IEZC6Fo1xAwMwSAR7zJItwfzwgdsRE3IgzOhrs7/Ka3JGcBSGf7hsocpi g==; X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="385157832" X-IronPort-AV: E=Sophos;i="6.03,237,1694761200"; d="scan'208";a="385157832" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2023 08:41:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="792050472" X-IronPort-AV: E=Sophos;i="6.03,237,1694761200"; d="scan'208";a="792050472" Received: from jiaminka-mobl1.gar.corp.intel.com (HELO intel.com) ([10.215.251.143]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2023 08:41:21 -0700 Date: Thu, 19 Oct 2023 17:41:12 +0200 From: Andi Shyti To: Soumya Negi Cc: Martyn Welch , Manohar Vanga , Greg Kroah-Hartman , Andi Shyti , Julia Lawall , outreachy@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH v2 2/2] staging: vme_user: Use __func__ instead of function name Message-ID: References: <996c9f92e7fd288f67c02dfb0ba524ab7c5fe421.1697696951.git.soumya.negi97@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <996c9f92e7fd288f67c02dfb0ba524ab7c5fe421.1697696951.git.soumya.negi97@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Soumya, On Thu, Oct 19, 2023 at 12:20:10AM -0700, Soumya Negi wrote: > Replace function names in message strings with __func__ to fix > all checkpatch warnings like: > > WARNING: Prefer using '"%s...", __func__' to using 'vme_lm_get', > this function's name, in a string > > Signed-off-by: Soumya Negi you forgot my ack here: Acked-by: Andi Shyti Andi > --- > Changes in v2: > * None > > drivers/staging/vme_user/vme.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c > index 640b2dda3ac6..e533cce8e54e 100644 > --- a/drivers/staging/vme_user/vme.c > +++ b/drivers/staging/vme_user/vme.c > @@ -424,7 +424,7 @@ int vme_slave_get(struct vme_resource *resource, int *enabled, > image = list_entry(resource->entry, struct vme_slave_resource, list); > > if (!bridge->slave_get) { > - dev_err(bridge->parent, "vme_slave_get not supported\n"); > + dev_err(bridge->parent, "%s not supported\n", __func__); > return -EINVAL; > } > > @@ -576,7 +576,7 @@ int vme_master_set(struct vme_resource *resource, int enabled, > image = list_entry(resource->entry, struct vme_master_resource, list); > > if (!bridge->master_set) { > - dev_warn(bridge->parent, "vme_master_set not supported\n"); > + dev_warn(bridge->parent, "%s not supported\n", __func__); > return -EINVAL; > } > > @@ -1576,7 +1576,7 @@ int vme_lm_set(struct vme_resource *resource, unsigned long long lm_base, > lm = list_entry(resource->entry, struct vme_lm_resource, list); > > if (!bridge->lm_set) { > - dev_err(bridge->parent, "vme_lm_set not supported\n"); > + dev_err(bridge->parent, "%s not supported\n", __func__); > return -EINVAL; > } > > @@ -1612,7 +1612,7 @@ int vme_lm_get(struct vme_resource *resource, unsigned long long *lm_base, > lm = list_entry(resource->entry, struct vme_lm_resource, list); > > if (!bridge->lm_get) { > - dev_err(bridge->parent, "vme_lm_get not supported\n"); > + dev_err(bridge->parent, "%s not supported\n", __func__); > return -EINVAL; > } > > @@ -1649,7 +1649,7 @@ int vme_lm_attach(struct vme_resource *resource, int monitor, > lm = list_entry(resource->entry, struct vme_lm_resource, list); > > if (!bridge->lm_attach) { > - dev_err(bridge->parent, "vme_lm_attach not supported\n"); > + dev_err(bridge->parent, "%s not supported\n", __func__); > return -EINVAL; > } > > @@ -1682,7 +1682,7 @@ int vme_lm_detach(struct vme_resource *resource, int monitor) > lm = list_entry(resource->entry, struct vme_lm_resource, list); > > if (!bridge->lm_detach) { > - dev_err(bridge->parent, "vme_lm_detach not supported\n"); > + dev_err(bridge->parent, "%s not supported\n", __func__); > return -EINVAL; > } > > @@ -1750,7 +1750,7 @@ int vme_slot_num(struct vme_dev *vdev) > } > > if (!bridge->slot_get) { > - dev_warn(bridge->parent, "vme_slot_num not supported\n"); > + dev_warn(bridge->parent, "%s not supported\n", __func__); > return -EINVAL; > } > > -- > 2.42.0