From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B9F3C001E0 for ; Sat, 21 Oct 2023 15:58:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231596AbjJUP65 (ORCPT ); Sat, 21 Oct 2023 11:58:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231604AbjJUP6z (ORCPT ); Sat, 21 Oct 2023 11:58:55 -0400 X-Greylist: delayed 10942 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sat, 21 Oct 2023 08:58:52 PDT Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1496398; Sat, 21 Oct 2023 08:58:52 -0700 (PDT) Received: from gaggiata.pivistrello.it (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id F2AFF207B8; Sat, 21 Oct 2023 17:58:49 +0200 (CEST) Received: from livingston (unknown [192.168.42.11]) by gaggiata.pivistrello.it (Postfix) with ESMTP id 9753C7FD86; Sat, 21 Oct 2023 17:58:49 +0200 (CEST) Received: from pivi by livingston with local (Exim 4.96) (envelope-from ) id 1quENF-0006bI-1Z; Sat, 21 Oct 2023 17:58:49 +0200 Date: Sat, 21 Oct 2023 17:58:49 +0200 From: Francesco Dolcini To: David Lin Cc: "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "briannorris@chromium.org" , "kvalo@kernel.org" , "francesco@dolcini.it" , Sharvari Harisangam , Pete Hsieh Subject: Re: [PATCH v6 1/6] wifi: mwifiex: added code to support host mlme. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello David, thanks for your patch. On Fri, Oct 20, 2023 at 03:48:11AM +0000, David Lin wrote: > 1. For station mode first. > 2. This feature is a must for WPA3. > 3. Firmware key api version 2 is needed for this feature. > 4. The code is only enabled and tested with IW416. > 5. This feature is disabled for other chips. > > Signed-off-by: David Lin > --- > .../net/wireless/marvell/mwifiex/cfg80211.c | 327 ++++++++++++++++++ > drivers/net/wireless/marvell/mwifiex/cmdevt.c | 14 +- > drivers/net/wireless/marvell/mwifiex/decl.h | 12 + > drivers/net/wireless/marvell/mwifiex/fw.h | 15 + > drivers/net/wireless/marvell/mwifiex/init.c | 3 + > drivers/net/wireless/marvell/mwifiex/join.c | 64 +++- > drivers/net/wireless/marvell/mwifiex/main.h | 10 + > drivers/net/wireless/marvell/mwifiex/scan.c | 6 + > drivers/net/wireless/marvell/mwifiex/sdio.c | 13 + > drivers/net/wireless/marvell/mwifiex/sdio.h | 2 + > .../net/wireless/marvell/mwifiex/sta_event.c | 18 +- > .../net/wireless/marvell/mwifiex/sta_ioctl.c | 3 +- > drivers/net/wireless/marvell/mwifiex/sta_tx.c | 9 +- > .../net/wireless/marvell/mwifiex/uap_cmd.c | 26 ++ > drivers/net/wireless/marvell/mwifiex/util.c | 73 ++++ > 15 files changed, 582 insertions(+), 13 deletions(-) > > diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c > index 7a15ea8072e6..40c39e4765f7 100644 > --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c > +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c > @@ -57,6 +57,31 @@ ieee80211_iface_combination mwifiex_iface_comb_ap_sta_drcs = { > .beacon_int_infra_match = true, > }; > > +struct mwifiex_ieee80211_mgmt { > + __le16 frame_control; > + __le16 duration; > + u8 da[ETH_ALEN]; > + u8 sa[ETH_ALEN]; > + u8 bssid[ETH_ALEN]; > + __le16 seq_ctrl; > + u8 addr4[ETH_ALEN]; > + union { > + struct { > + __le16 auth_alg; > + __le16 auth_transaction; > + __le16 status_code; > + /* possibly followed by Challenge text */ > + u8 variable[]; > + } __packed auth; > + struct { > + __le16 capab_info; > + __le16 listen_interval; > + /* followed by SSID and Supported rates */ > + u8 variable[]; > + } __packed assoc_req; > + } u; > +} __pack; I noticed that you ignored some (all?) of my feedback [1]. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Francesco [1] https://lore.kernel.org/all/ZRLsuJfxuvFk1K16@francesco-nb.int.toradex.com/