From: Jules Irenge <jbi.octave@gmail.com>
To: tglx@linutronix.de
Cc: mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
x86@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org,
petr.pavlu@suse.com
Subject: [PATCH] x86/kprobes: Remove unnecessary extern keyword
Date: Sat, 21 Oct 2023 23:18:43 +0100 [thread overview]
Message-ID: <ZTROQyJ4xp75e0dA@octux.home> (raw)
Sparse reports a warning at arch_unoptimize_kprobes()
warning: function "arch_unoptimize_kprobes"
with external linkage has definition
The reason is the function is already declared in the header file
as extern
Remove unnecessary "extern" keyword
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
arch/x86/kernel/kprobes/opt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/kprobes/opt.c b/arch/x86/kernel/kprobes/opt.c
index 517821b48391..f20ea996abbf 100644
--- a/arch/x86/kernel/kprobes/opt.c
+++ b/arch/x86/kernel/kprobes/opt.c
@@ -526,8 +526,8 @@ void arch_unoptimize_kprobe(struct optimized_kprobe *op)
* Recover original instructions and breakpoints from relative jumps.
* Caller must call with locking kprobe_mutex.
*/
-extern void arch_unoptimize_kprobes(struct list_head *oplist,
- struct list_head *done_list)
+void arch_unoptimize_kprobes(struct list_head *oplist,
+ struct list_head *done_list)
{
struct optimized_kprobe *op, *tmp;
--
2.41.0
reply other threads:[~2023-10-21 22:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTROQyJ4xp75e0dA@octux.home \
--to=jbi.octave@gmail.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=petr.pavlu@suse.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®