From: Nicolin Chen <nicolinc@nvidia.com>
To: Baolu Lu <baolu.lu@linux.intel.com>
Cc: <jgg@nvidia.com>, <kevin.tian@intel.com>, <joro@8bytes.org>,
<will@kernel.org>, <robin.murphy@arm.com>,
<iommu@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<yi.l.liu@intel.com>
Subject: Re: [PATCH 1/2] iommufd/device: Drop enforce_cache_coherency in iommufd_device_do_replace
Date: Sun, 22 Oct 2023 17:25:50 -0700 [thread overview]
Message-ID: <ZTW9jnyhBNZm8p0+@Asurada-Nvidia> (raw)
In-Reply-To: <f840af3a-45fe-477e-bd45-2bee95b8c8d5@linux.intel.com>
On Sat, Oct 21, 2023 at 09:25:18AM +0800, Baolu Lu wrote:
> > @@ -465,6 +455,8 @@ iommufd_device_do_replace(struct iommufd_device *idev,
> >
> > igroup->hwpt = hwpt;
> >
> > + list_for_each_entry(cur, &igroup->device_list, group_item)
> > + num_devices++;
>
> Minor: How about using list_count_nodes()?
That's better I think. Replaced with:
+ num_devices = list_count_nodes(&igroup->device_list);
> > /*
> > * Move the refcounts held by the device_list to the new hwpt. Retain a
> > * refcount for this thread as the caller will free it.
>
> Either way,
>
> Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
Thanks!
Nic
next prev parent reply other threads:[~2023-10-23 0:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-21 0:37 [PATCH 0/2] iommufd: Only enforce_cache_coherency when allocating hwpt Nicolin Chen
2023-10-21 0:37 ` [PATCH 1/2] iommufd/device: Drop enforce_cache_coherency in iommufd_device_do_replace Nicolin Chen
2023-10-21 1:25 ` Baolu Lu
2023-10-23 0:25 ` Nicolin Chen [this message]
2023-10-21 0:37 ` [PATCH 2/2] iommufd/device: Drop enforce_cache_coherency in iommufd_hw_pagetable_attach Nicolin Chen
2023-10-21 1:26 ` Baolu Lu
2023-10-21 1:32 ` [PATCH 0/2] iommufd: Only enforce_cache_coherency when allocating hwpt Baolu Lu
2023-10-21 16:39 ` Jason Gunthorpe
2023-10-23 2:55 ` Tian, Kevin
2023-10-23 3:09 ` Baolu Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTW9jnyhBNZm8p0+@Asurada-Nvidia \
--to=nicolinc@nvidia.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®