From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Christopher Obbard <chris.obbard@collabora.com>
Cc: Sebastian Reichel <sebastian.reichel@collabora.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@collabora.com, stable@vger.kernel.org
Subject: Re: [PATCH v1 1/2] clk: composite: Fix handling of high clock rates
Date: Tue, 24 Oct 2023 14:17:35 +0300 [thread overview]
Message-ID: <ZTenz66dqsdUfz1t@smile.fi.intel.com> (raw)
In-Reply-To: <c8befb46085c43e1d09f27709b90e92dbce52c82.camel@collabora.com>
On Sat, May 20, 2023 at 08:57:16AM +0100, Christopher Obbard wrote:
> On Fri, 2023-05-19 at 21:05 +0200, Sebastian Reichel wrote:
...
> > - rate_diff = abs(req->rate - tmp_req.rate);
> > + if (req->rate >= tmp_req.rate)
> > + rate_diff = req->rate - tmp_req.rate;
> > + else
> > + rate_diff = tmp_req.rate - req->rate;
Btw, we have abs_diff() helper for this kind of cases.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-10-24 11:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 19:05 [PATCH v1 0/2] Fix 64 bit issues in common clock framework Sebastian Reichel
2023-05-19 19:05 ` [PATCH v1 1/2] clk: composite: Fix handling of high clock rates Sebastian Reichel
2023-05-20 7:57 ` Christopher Obbard
2023-10-24 11:17 ` Andy Shevchenko [this message]
2023-05-19 19:05 ` [PATCH v1 2/2] clk: divider: Properly handle rates exceeding UINT_MAX Sebastian Reichel
2023-05-20 7:57 ` Christopher Obbard
2023-05-22 8:18 ` David Laight
2023-05-25 23:01 ` 'Sebastian Reichel'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTenz66dqsdUfz1t@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=chris.obbard@collabora.com \
--cc=kernel@collabora.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®