From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EF84C25B48 for ; Thu, 26 Oct 2023 12:22:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229980AbjJZMWd (ORCPT ); Thu, 26 Oct 2023 08:22:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229642AbjJZMWb (ORCPT ); Thu, 26 Oct 2023 08:22:31 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D42F1AA; Thu, 26 Oct 2023 05:22:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698322949; x=1729858949; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=XhkCuEPgG658NDvItUy3K7Wo+EY9Pgf5oTkmj458HrQ=; b=n5my4YhYQT1qtaRDwqOl9sU9UcDxlpPY0XYQDaP+ZoF+0Ax1VUB+WVbD /T5ui7N7ty+fu3oe8Msr2zynkP/BtbFDcKI0j5fwcGY6WvF2FLyLpoAEU Be1XiMcw7lVPb/c0lgZZxUdaWU+3KnE+bw6s8DW8bt3h722JmVg75FivP 1NxdvaskaDtQ8bd1s3BviAm8fTe2PUcPBgn4CWkeRT9hMvnuSBRShJLrX tOseAaEb+gh1pxP+ztGCcJMooxJBCjNTClzJJyCj3faS03JUUTSDxwegL 7ersEEo7/RtiyboT/HBxNPnM2AK4Aqs3qpHE4tWOyOqDehdTdRiXuBNyE g==; X-IronPort-AV: E=McAfee;i="6600,9927,10874"; a="390391620" X-IronPort-AV: E=Sophos;i="6.03,253,1694761200"; d="scan'208";a="390391620" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2023 05:22:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10874"; a="902883942" X-IronPort-AV: E=Sophos;i="6.03,253,1694761200"; d="scan'208";a="902883942" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga001.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2023 05:20:01 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC3) (envelope-from ) id 1qvzNY-00000008qpQ-1OYO; Thu, 26 Oct 2023 15:22:24 +0300 Date: Thu, 26 Oct 2023 15:22:24 +0300 From: Andy Shevchenko To: Michal Wilczynski Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, rafael.j.wysocki@intel.com, lenb@kernel.org Subject: Re: [PATCH v1 3/6] ACPI: acpi_video: Remove unnecessary driver_data clear Message-ID: References: <20231025111806.2416524-1-michal.wilczynski@intel.com> <20231025111806.2416524-4-michal.wilczynski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231025111806.2416524-4-michal.wilczynski@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 25, 2023 at 02:18:03PM +0300, Michal Wilczynski wrote: > Commit > 0d16710146a1 ("ACPI: bus: Set driver_data to NULL every time .add() fails") It's fine to wrap it here, it's just a restriction in the tag block that one tag == one line. Also I believe the form "The commit" sounds more English :-) as reader knows exact commit we are talking about. > introduced clearing driver_data every time probe fails, so it's not > necessary to clear it in the probe() callback. > Remove NULL assignment to driver_data in error path in > acpi_video_bus_add(). This can be one line. -- With Best Regards, Andy Shevchenko