From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AE8DC4332F for ; Sat, 11 Nov 2023 01:55:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345356AbjKKBzC (ORCPT ); Fri, 10 Nov 2023 20:55:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230101AbjKKBzB (ORCPT ); Fri, 10 Nov 2023 20:55:01 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F7AD44B3 for ; Fri, 10 Nov 2023 17:54:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699667698; x=1731203698; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=7QNnnGBdo2QTy+K6/lNyGjnVdtfTXeNE5QSVk7PPDHM=; b=KlJ0+sV7B8F+Cecb0f903wO026S4YYl8bhMrUUQwZS7KjmOT0DeDOaRr MDVvwhUgc3l/jIG4iKVi2mqOirbt9b5dkPflyXqgFf/O7Rib0NJBU6ij6 0WN12wbDEFa4AXPWlVTs6NjWOV2Ucj7ohEt1MvcT4XZyqVl4Z3DsfSgpe DLqatsEjz7/INl6bOFRy4vMeuC+WsBCbJwnR+KzP5/Z0sGH+KjifLeYM4 l5SnkbOKFRsAniX0fMBLTDga1/d5DtZlx6JgXzh4ihdzSN8D3kw5y9Cco 62D01iV6eItxX1WGWgqXsfW1zWhNZ6fE+IhUjAvKz4qMexqYiEtuHXqDe w==; X-IronPort-AV: E=McAfee;i="6600,9927,10890"; a="390058147" X-IronPort-AV: E=Sophos;i="6.03,293,1694761200"; d="scan'208";a="390058147" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2023 17:54:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10890"; a="937296371" X-IronPort-AV: E=Sophos;i="6.03,293,1694761200"; d="scan'208";a="937296371" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 10 Nov 2023 17:54:57 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 10 Nov 2023 17:54:50 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Fri, 10 Nov 2023 17:54:50 -0800 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.40) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Fri, 10 Nov 2023 17:54:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=konKcVLqjpwyd0XtslcuQZ0VWmKsdRTq82oEz+KfmI2sRu3EvwbxkgwPlkxWjE1bu/yAEcX8TAgnvFWBNTOr6nwvJI/FeF8uH9nzZdZkX1JVAbdhXOaMzYEfnj+mx9e31oJmnQPhbJ1YExPSmTdbZyEQWtTrItoELQnCDHoNCJwKVbLndSAg1FkDutLzZE8APWXsWcpuH3Bo5CD72bMFICj5F3XRdNufpgESnSc9W+Vv1gWP3pHMhk8ObogfjGsMGcfLvd3eqJOLHzP6vHXAPnyC/G1qQNgMsLFYJ5Dr8LmkoJ6kKgNwVBWzTlAL0qb2EULFxGe/G0dOFBGjeRhgMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5GDzO2+xf1b9ZW6h+mX8B9BhJ8FTh5Tb7sWXM9Geifg=; b=f71/SkKaf3Z5cPwldeaj3V+0ktYvfykgTkjWfYcrv8a46sLfXAoqQ5pbptAbKugicJCVc0G0XXpNHrd9KCLpIjCjD0Z5TloGRoQ3eLUdn9TY+LIHmB7cotuBisNyqCMz23RhQ2ar7GIGyvfzYof/n+3O5PYwMAWMg/IuwAQrS6Ghb2O6T6Xh+pTIHGC1uI7kN64dgJc2vYry9R4e+nnN5Lg/K7prJ6JRbI8A+fcOqJwJvyePjTPzn29WDYdr3vZpDZMeCzGOcP8OWVB7uVKbySklGtvy15UNi2mFCEr89AY5RuJXUhuYbMZvwCrQoxUqzXHXWHmeKjNe9BoPOrOIGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from BL0PR11MB2995.namprd11.prod.outlook.com (2603:10b6:208:7a::28) by PH7PR11MB5818.namprd11.prod.outlook.com (2603:10b6:510:132::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.22; Sat, 11 Nov 2023 01:54:42 +0000 Received: from BL0PR11MB2995.namprd11.prod.outlook.com ([fe80::2f1a:e62e:9fff:ae67]) by BL0PR11MB2995.namprd11.prod.outlook.com ([fe80::2f1a:e62e:9fff:ae67%4]) with mapi id 15.20.6954.029; Sat, 11 Nov 2023 01:54:42 +0000 Date: Sat, 11 Nov 2023 09:54:33 +0800 From: Philip Li To: Sebastian Andrzej Siewior CC: kernel test robot , , , Thomas Gleixner Subject: Re: lib/flex_proportions.c:73:9: sparse: sparse: incorrect type in argument 1 (different address spaces) Message-ID: References: <202311080840.Vc2kXhfp-lkp@intel.com> <20231110154208.5UoC_qsI@linutronix.de> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231110154208.5UoC_qsI@linutronix.de> X-ClientProxiedBy: SG2PR04CA0165.apcprd04.prod.outlook.com (2603:1096:4::27) To BL0PR11MB2995.namprd11.prod.outlook.com (2603:10b6:208:7a::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR11MB2995:EE_|PH7PR11MB5818:EE_ X-MS-Office365-Filtering-Correlation-Id: 11f041b0-2cce-4e51-30ee-08dbe2592bc9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o3BzmSQDJ48dXC6rLiJ9fuy/r+vH8uV8wQXHAZaAZgKZPej2hAzfMN/Vi5s/MV3CjUAocDDmALwWqUohj59L1OTw/uVZjCVchSv/Rgwa//J/WnwtUWztzau47LMxXRjlAd0kgHOba4xRNuRL0dRnrkTvlNxweMXdXwxzgAuJ9cVO1UC/Vehzt1elurtwyRAMWgyKgDSJpkjzjp34DjhJgjzJRK3QWcRBY/3f+nhHqKENisDkmyIjzm6STt2ESuzt9Eb0vnntYaWt0rDy0QGjgnkrU4HmvCKtPWQwNpo4FfpViqq5AfhoCZDpgwDef54YiSUVpx3KS7o/71wZYpkvTLqUOdMRPwo30dqFQE+8BovVl1fctRgCXvc5BB4pwSDCfjU6exskTqr+qKIQbqPLg3xJLkwgL7Y/MStKgjHHuCis2mKbVb7GFqy9p5FtleGl6beO2bi9g1MFU3CzcKLIwZi+552Eiljdw72gJVfhFJaxX87s0IIKTFlK3k57+PDdZ3MR4ohTWVTK7QiqA3BLrsS3SdSvMdRe9AsXMTBnLsWrQMylUfQaBHQHrVRzfEkhnWjKqJUp8Xy9/J47JrfB9naNJu6z5xPSC9ShQMlsxy9KHIYEOfAsgGHA+CzDNgO4 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR11MB2995.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7916004)(366004)(376002)(346002)(39860400002)(136003)(396003)(230922051799003)(230173577357003)(230273577357003)(451199024)(186009)(1800799009)(64100799003)(2906002)(44832011)(5660300002)(86362001)(41300700001)(33716001)(26005)(82960400001)(54906003)(66556008)(66946007)(66476007)(6916009)(9686003)(6512007)(316002)(83380400001)(38100700002)(6666004)(478600001)(6486002)(53546011)(6506007)(8676002)(4326008)(8936002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d1ZrZVUwUVZWY3FkcUw3UlNTeVFnRGpRSUlUeVJtemZtM0xJUktIR2tTdEpD?= =?utf-8?B?V2txeHhCZ09BZnE4QllTeW00emIxbEJqTENpTWpUMHJzN3FzZm05YXJlak05?= =?utf-8?B?ekREOU9BOEg0Y0RtcjFKQjg0Vm56VHFEQXNqdnlMUGYwN2NGQzF6UXU0bm5t?= =?utf-8?B?Yi8wRExDaDhaOWcxT29RbkMrMlFTL09Tb1o1UlZLVlBDdmJjelYvZGtGNE1h?= =?utf-8?B?VTE3czYyY3BDTlVub3l2YTRUQ1RRbUtCL0dGTjRtOG4xcHJtRG5KVEprZlMx?= =?utf-8?B?Qk5hNTQwTXc5ZlZIQk9tazZDbGlGQTlFT0JkQWlkRnhibmVXNU9va0Z3ZTVY?= =?utf-8?B?d3dzSGlHMWRWUHhkUWptYnB6T0VqMjZNSUhFcmgySGtrekV4dkVrMFp4Qk04?= =?utf-8?B?T0VzaGdKR3FiUHNoRGRPRW42dEsvY3Y0bGozTUVDbEpyZ2llbm85KytQOEFU?= =?utf-8?B?TmQvOHFMR0t4TktyNkVPdUxjRTJWYzJsOUhtSXlaUXBianY1MUxlNXZ1QW5U?= =?utf-8?B?czlDNFY4RjhybStCTTJPOXlNVnpUU2dGL1dxdCtmQTQ5S09vcWxiTHQxdWtW?= =?utf-8?B?eHU3Y3N4a1JSRHVVRnFhVG93ZmtXWExwRU1lYUg0VTJYRW1UQXhKeUlxMHNw?= =?utf-8?B?aHdSRzRDQitiRkxma1Z4cllYQkV2YjdTd1dCajE0ZW44MzZ4MzMzUXcvc1hM?= =?utf-8?B?a1VTUWNtRy9KMG4yTFB2dGNkSEI2R0tQaHBMUUQ5bzBNUmZJSTJDaHFMZUJn?= =?utf-8?B?ZHFUZHFMYkJjeG9BajYwNG5DWlR4TDdqdUQzc0xuTDMxNnRBRms1WHhqTTBa?= =?utf-8?B?WC80WDMycW5PdzNTblllS1VSZWhxR2x4TDhPbFZEQmJCL29hSHN5VytkbUE2?= =?utf-8?B?TlJKNGRtK1RiOFRKSzN3WDJaZW1MZjBIWnRlNGp1MTFxaUZINm4vbnlzUzk3?= =?utf-8?B?eDdKUml6VFdHTmJJMFlLZ1B6UCt6MWs0NithamlxUVp5dnVJNUFGVzBQYWMz?= =?utf-8?B?cGRRVGxwcHh2dkVUWktaK1RTL045V2k4Ly9QWXBMZWNhcEh1aVRCZHhCVHcx?= =?utf-8?B?d2hhdmMxRDZuUEg0NzlKMGxRbDZ2OURoczhML1RnRVdjalI1a20wMmwyR1pS?= =?utf-8?B?azl0WDFLVllpVHdHaVJxNXlQaXlMSkxDVkVtYkt2WjlPbnh2RHJTempRcDZs?= =?utf-8?B?aUkrelp6NmZheHVzY1ZZaEVXLzBqNUc2YVdGZm0rVG9WU1pWK01CT1pKRnZ5?= =?utf-8?B?ZkxNSStSbmRBRTJ6eDlMKytzenpxSHZUOWU2clJ0VEVoYTA2S1IybXRPZEtM?= =?utf-8?B?MTBLTlA1NlVUWE5ITVpWR1I5Zlkva2lXcEtxRlpZeEdSUzRHd1ZMalFiK0pJ?= =?utf-8?B?eG1kV2c5RlhRQzRVQTNKM3pOZDh6QWtadDRzS09xZVB0M1A2S3JtWGI3Umh1?= =?utf-8?B?b1pnakwyS09ZVFI5VllxWldmYm5ab0dvMkJmNFNZVExBWjZyd2l5a2s5bVMr?= =?utf-8?B?dWJkWjZKQSthOFY5K2JNUm9RV2FmT0V5bnpkY3l0ZXplSUVNcVhoZEpqYTFo?= =?utf-8?B?SmZWUWppajJxYWZ1R1Q4UXpMN2ZkSjNyanpaL2tBckoyWEdSUVJrNHBnWUV4?= =?utf-8?B?MCtBZFhRUTkzelJmSjEyUldMSk81Zkc1dGtTdDhqN1RPN3BKa0x3QVZDZmZj?= =?utf-8?B?aWliZlREcUQrL0t4Z0pIVThRMDlMMHJjUFA2SWFacjU0RGRmT1NQRDlSY2s3?= =?utf-8?B?d1hQSDdERytpRFNtbnN4ZjVORFVHTU10cG80MXBPc1V1MGtmdVpYdno3RjUx?= =?utf-8?B?ZHFUa1VjZjVYcnVrQTBITmEwVHZaMStzMlM5VmlocE9US1VMYjlqMmtLSFg0?= =?utf-8?B?V2k0aUkwbjRZb0lGMjZvTEIyd2dPUmFRRGZtNnJ5bWxtRk1UTHhwOU1mZkhh?= =?utf-8?B?UnV5Q2ZTSkdVbmhnUEQrVUNKZi9vZnJJRjZOVldweEZFaUhhSEZFcEh6cjZ0?= =?utf-8?B?KzhpdlNDV1EzT2QxTEUxMjEvRWhsUzVhQ3hFdlBYb2V0SWtUMjU4MkJJWjFM?= =?utf-8?B?blVtbEZ1NllDVWJURlJxMHVNckEybWNZcVBpVFpCalpmSzFUY2VyM3pidjhz?= =?utf-8?Q?hf5eOfizEb4hkuHHRufEnwqrP?= X-MS-Exchange-CrossTenant-Network-Message-Id: 11f041b0-2cce-4e51-30ee-08dbe2592bc9 X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB2995.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2023 01:54:42.0810 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qo0S5HBgbWmxSi7o7X/Xhz6e9QdWhpYiX/GZT/h2GtaIeldOP/md/xnTZOLDwWhZ463usFWLwPBv7NZGr8fZOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5818 X-OriginatorOrg: intel.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 10, 2023 at 04:42:08PM +0100, Sebastian Andrzej Siewior wrote: > On 2023-11-08 09:04:40 [+0800], kernel test robot wrote: > … > Could you please explain what is wrong here? The code in line 73 has no > percpu reference at all. Or expects an argument. Apologize for the confusing report, we will investigate this in earliest time to understand what goes wrong. Kindly ignore this and sorry for the noise. > > > sparse warnings: (new ones prefixed by >>) > > >> lib/flex_proportions.c:73:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got unsigned int [noderef] __percpu * @@ > > lib/flex_proportions.c:73:9: sparse: expected void *ptr > > lib/flex_proportions.c:73:9: sparse: got unsigned int [noderef] __percpu * > > >> lib/flex_proportions.c:73:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got unsigned int [noderef] __percpu * @@ > > lib/flex_proportions.c:73:9: sparse: expected void *ptr > > lib/flex_proportions.c:73:9: sparse: got unsigned int [noderef] __percpu * > > >> lib/flex_proportions.c:73:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got unsigned int [noderef] __percpu * @@ > > lib/flex_proportions.c:73:9: sparse: expected void *ptr > > lib/flex_proportions.c:73:9: sparse: got unsigned int [noderef] __percpu * > > >> lib/flex_proportions.c:73:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got unsigned int [noderef] __percpu * @@ > > lib/flex_proportions.c:73:9: sparse: expected void *ptr > > lib/flex_proportions.c:73:9: sparse: got unsigned int [noderef] __percpu * > > >> lib/flex_proportions.c:73:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got int [noderef] __percpu * @@ > > lib/flex_proportions.c:73:9: sparse: expected void *ptr > > lib/flex_proportions.c:73:9: sparse: got int [noderef] __percpu * > > >> lib/flex_proportions.c:73:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got int [noderef] __percpu * @@ > > lib/flex_proportions.c:73:9: sparse: expected void *ptr > > lib/flex_proportions.c:73:9: sparse: got int [noderef] __percpu * > > >> lib/flex_proportions.c:73:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got int [noderef] __percpu * @@ > > lib/flex_proportions.c:73:9: sparse: expected void *ptr > > lib/flex_proportions.c:73:9: sparse: got int [noderef] __percpu * > > >> lib/flex_proportions.c:73:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got int [noderef] __percpu * @@ > > lib/flex_proportions.c:73:9: sparse: expected void *ptr > > lib/flex_proportions.c:73:9: sparse: got int [noderef] __percpu * > > lib/flex_proportions.c: note: in included file (through include/linux/mmzone.h, include/linux/gfp.h, include/linux/percpu_counter.h, ...): > > > > vim +73 lib/flex_proportions.c > > > > 55 > > 56 /* > > 57 * Declare @periods new periods. It is upto the caller to make sure period > > 58 * transitions cannot happen in parallel. > > 59 * > > 60 * The function returns true if the proportions are still defined and false > > 61 * if aging zeroed out all events. This can be used to detect whether declaring > > 62 * further periods has any effect. > > 63 */ > > 64 bool fprop_new_period(struct fprop_global *p, int periods) > > 65 { > > 66 s64 events = percpu_counter_sum(&p->events); > > 67 > > 68 /* > > 69 * Don't do anything if there are no events. > > 70 */ > > 71 if (events <= 1) > > 72 return false; > > > 73 preempt_disable_nested(); > > 74 write_seqcount_begin(&p->sequence); > > 75 if (periods < 64) > > 76 events -= events >> periods; > > 77 /* Use addition to avoid losing events happening between sum and set */ > > 78 percpu_counter_add(&p->events, -events); > > 79 p->period += periods; > > 80 write_seqcount_end(&p->sequence); > > 81 preempt_enable_nested(); > > 82 > > 83 return true; > > 84 } > > 85 > > > Sebastian >