From: Pavel Machek <pavel@ucw.cz>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: bcousson@baylibre.com, tony@atomide.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: omap4: embt2ws: add LED
Date: Tue, 31 Oct 2023 10:16:35 +0100 [thread overview]
Message-ID: <ZUDF8zuKdYp/k0ox@duo.ucw.cz> (raw)
In-Reply-To: <20230819143109.471615-1-andreas@kemnade.info>
[-- Attachment #1: Type: text/plain, Size: 946 bytes --]
Hi!
> Add LED since the driver is now available.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Is it one LED or three LEDs?
If it is one, we should use multicolor...
BR,
Pavel
> @@ -206,7 +207,31 @@ &i2c3 {
>
> clock-frequency = <100000>;
>
> - /* TODO: BD2606MVV at 0x66 */
> + led-controller@66 {
> + compatible = "rohm,bd2606mvv";
> + reg = <0x66>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + led@0 {
> + reg = <0>;
> + color = <LED_COLOR_ID_GREEN>;
> + function = LED_FUNCTION_STATUS;
> + };
> +
> + led@2 {
> + reg = <2>;
> + color = <LED_COLOR_ID_BLUE>;
> + function = LED_FUNCTION_STATUS;
> + };
> +
> + led@4 {
> + reg = <4>;
> + color = <LED_COLOR_ID_RED>;
> + function = LED_FUNCTION_STATUS;
> + };
> + };
> };
>
> &i2c4 {
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
prev parent reply other threads:[~2023-10-31 9:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-19 14:31 Andreas Kemnade
2023-09-26 7:19 ` Tony Lindgren
2023-10-31 9:16 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUDF8zuKdYp/k0ox@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=andreas@kemnade.info \
--cc=bcousson@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®