From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Hans de Goede <hdegoede@redhat.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Revert "media: imx290: Convert to new CCI register access helpers"
Date: Wed, 1 Nov 2023 10:31:44 +0000 [thread overview]
Message-ID: <ZUIpEJmmdGTFdx09@kekkonen.localdomain> (raw)
In-Reply-To: <20231101100900.224567-1-alexander.stein@ew.tq-group.com>
Hi Alexander,
On Wed, Nov 01, 2023 at 11:09:00AM +0100, Alexander Stein wrote:
> cci_write() unconditionally writes multi-byte data in big-endian format.
> But IMX290 and IMX327 use little-endian format for multi-byte registers.
> Revert the CCI usage until little-endian is supported by CCI register
> access helpers.
> This reverts commit af73323b97702e53b0a336972aaf23e7dd92c850.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> The difference is subtile, but imx290_write() uses put_unaligned_le24(),
> while cci_write() uses put_unaligned_be24().
>
> I assume this should go into stable as well. How to deal with that?
> Shall a revert get the fixes tag as well?
I'd very much prefer addressing this in v4l2-cci instead. It should also be
a much smaller patch (or patches).
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2023-11-01 10:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 10:09 Alexander Stein
2023-11-01 10:31 ` Sakari Ailus [this message]
2023-11-01 10:41 ` Hans de Goede
2023-11-01 10:53 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUIpEJmmdGTFdx09@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=hdegoede@redhat.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®