From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v2 6/7] drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back
Date: Thu, 2 Nov 2023 16:19:46 +0200 [thread overview]
Message-ID: <ZUOwAn158pUELTBq@smile.fi.intel.com> (raw)
In-Reply-To: <f68dca47-d9ed-a146-b152-c19bcc9d8828@redhat.com>
On Wed, Nov 01, 2023 at 11:20:23AM +0100, Hans de Goede wrote:
> On 11/1/23 10:32, Andy Shevchenko wrote:
> > On Tue, Oct 31, 2023 at 10:15:52PM +0100, Hans de Goede wrote:
> >> On 10/31/23 17:07, Hans de Goede wrote:
> >>> On 10/24/23 18:11, Andy Shevchenko wrote:
> >>>> On Tue, Oct 24, 2023 at 06:57:38PM +0300, Andy Shevchenko wrote:
...
> Note you still need the first part of my patch which is
> an unrelated bugfix:
>
> --- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
> +++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
> @@ -219,8 +219,7 @@ static void soc_exec_gpio(struct intel_connector *connector, const char *con_id,
> } else {
> gpio_desc = devm_gpiod_get_index(dev_priv->drm.dev,
> con_id, gpio_index,
> - value ? GPIOD_OUT_LOW :
> - GPIOD_OUT_HIGH);
> + value ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW);
> if (IS_ERR(gpio_desc)) {
> drm_err(&dev_priv->drm,
> "GPIO index %u request failed (%pe)\n",
Can you attach or send a formal submission, so I can incorporate it into one
(v3) series among other changes?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-11-02 14:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 15:57 [rft, PATCH v2 0/7] drm/i915/dsi: 2nd attempt to get rid of IOSF GPIO Andy Shevchenko
2023-10-24 15:57 ` [PATCH v2 1/7] drm/i915/dsi: Replace while(1) with one with clear exit condition Andy Shevchenko
2023-10-25 9:15 ` [Intel-gfx] " Andi Shyti
2023-10-24 15:57 ` [PATCH v2 2/7] drm/i915/dsi: Get rid of redundant 'else' Andy Shevchenko
2023-10-25 9:18 ` [Intel-gfx] " Andi Shyti
2023-10-24 15:57 ` [PATCH v2 3/7] drm/i915/dsi: Replace check with a (missing) MIPI sequence name Andy Shevchenko
2023-10-25 9:24 ` [Intel-gfx] " Andi Shyti
2023-10-24 15:57 ` [PATCH v2 4/7] drm/i915/dsi: Extract common soc_gpio_exec() helper Andy Shevchenko
2023-10-24 15:57 ` [PATCH v2 5/7] drm/i915/dsi: Replace poking of VLV GPIOs behind the driver's back Andy Shevchenko
2023-10-24 15:57 ` [PATCH v2 6/7] drm/i915/dsi: Replace poking of CHV " Andy Shevchenko
2023-10-24 16:11 ` Andy Shevchenko
2023-10-31 16:07 ` Hans de Goede
2023-10-31 16:21 ` Andy Shevchenko
2023-10-31 21:15 ` Hans de Goede
2023-11-01 9:32 ` Andy Shevchenko
2023-11-01 10:20 ` Hans de Goede
2023-11-01 10:34 ` [Intel-gfx] " Ville Syrjälä
2023-11-01 10:40 ` Hans de Goede
2023-11-01 11:01 ` Hans de Goede
2023-11-02 12:27 ` Andy Shevchenko
2023-11-02 14:19 ` Andy Shevchenko [this message]
2023-11-02 14:28 ` Hans de Goede
2023-10-24 15:57 ` [PATCH v2 7/7] drm/i915/iosf: Drop unused APIs Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUOwAn158pUELTBq@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®