From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 331E7C4167D for ; Fri, 3 Nov 2023 14:30:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377878AbjKCOaj (ORCPT ); Fri, 3 Nov 2023 10:30:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377836AbjKCOaf (ORCPT ); Fri, 3 Nov 2023 10:30:35 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB808D4D; Fri, 3 Nov 2023 07:30:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=TutFGcTUbbtZZeHXA63UR/SNK49qiEmJWb/gtgYEieI=; b=FbyJVXsJzK7XKpDQhQSH2f5bbB EgnQqqd9A9MFrtDCw2kOiVC1DIyBIwkyxlhwtCFXD4kA29mLsIB2wnynfa+ilpkl4TDa+mlRCGUQe bWhB9NrNZ6N8a2BJoYER/YL5yFnOOOynx4Ntax3dLv5EjBGKpDj2bljHRIgrQ+yhvyLmlCKvwtpD5 txs3wPs/dADpxkPkUXf9pmOa/WA3wpJwY3mFWqRJarMd6nYaQf+TRGQvYWVUM5qFNc+hNSK3qeSqU Xor8VEwOvcszB2K2Ci/7a62ltupYnMXN6gdoUfddkshXy82ilrp/FDK4sJRxXmk1Fx8uhoQ2e0Yne T6r8e5EA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qyvBp-005rhq-Os; Fri, 03 Nov 2023 14:30:25 +0000 Date: Fri, 3 Nov 2023 14:30:25 +0000 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Hildenbrand , linux-s390@vger.kernel.org Subject: Re: [PATCH rfc 00/18] mm: convert to use folio mm counter Message-ID: References: <20231103140119.2306578-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231103140119.2306578-1-wangkefeng.wang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 03, 2023 at 10:01:01PM +0800, Kefeng Wang wrote: > Convert mm counter page functions to folio ones. > > mm_counter() -> mm_counter_folio() > mm_counter_file() -> mm_counter_file_folio() > > Maybe it's better to rename folio mm counter function back to mm_counter() > and mm_counter_file() after all conversion? I deliberately didn't do this because it's mostly churn. Once all callers of mm_counter() and mm_counter_file() have been converted to use folios, we can do one big patch to convert all callers to pass a folio instead of a page.