mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: Jeremy Cline <jeremy@jcline.org>
Cc: Edward Adam Davis <eadavis@qq.com>,
	habetsm.xilinx@gmail.com, davem@davemloft.net,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	reibax@gmail.com,
	syzbot+df3f3ef31f60781fa911@syzkaller.appspotmail.com,
	syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH net-next V2] ptp: fix corrupted list in ptp_open
Date: Fri, 3 Nov 2023 19:13:31 -0700	[thread overview]
Message-ID: <ZUWoyxIgl6vDFsjp@hoboy.vegasvil.org> (raw)
In-Reply-To: <ZUPnlsm91R72MBs7@dev>

On Thu, Nov 02, 2023 at 02:16:54PM -0400, Jeremy Cline wrote:

> While this patch looks to cover adding and removing items from the list,
> the code that iterates over the list isn't covered which can be
> problematic. If the list is modified while it is being iterated, the
> iterating code could chase an invalid pointer.

Indeed.

See ptp_clock.c:

 416         case PTP_CLOCK_EXTTS:
 417                 /* Enqueue timestamp on selected queues */
 418                 list_for_each_entry(tsevq, &ptp->tsevqs, qlist) {
 419                         if (test_bit((unsigned int)event->index, tsevq->mask))
 420                                 enqueue_external_timestamp(tsevq, event);
 421                 }
 422                 wake_up_interruptible(&ptp->tsev_wq);
 423                 break;

Thanks,
Richard

  reply	other threads:[~2023-11-04  2:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tencent_2C67C6D2537B236F497823BCC457976F9705@qq.com>
2023-11-02  0:18 ` Richard Cochran
2023-11-02 18:16 ` Jeremy Cline
2023-11-04  2:13   ` Richard Cochran [this message]
2023-11-04  2:15     ` Richard Cochran
2023-10-29 19:57 [PATCH-net-next] " Richard Cochran
     [not found] ` <tencent_24C96E7894D0EBA2EDD2CFB87BB66EC02D0A@qq.com>
2023-10-31  9:28   ` [PATCH net-next V2] " Martin Habets
2023-11-02  0:12   ` Richard Cochran
     [not found]     ` <tencent_ACEACCAC786A6F282DF16DCC95C8E852ED0A@qq.com>
2023-11-03 23:15       ` Richard Cochran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZUWoyxIgl6vDFsjp@hoboy.vegasvil.org \
    --to=richardcochran@gmail.com \
    --cc=davem@davemloft.net \
    --cc=eadavis@qq.com \
    --cc=habetsm.xilinx@gmail.com \
    --cc=jeremy@jcline.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=reibax@gmail.com \
    --cc=syzbot+df3f3ef31f60781fa911@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®