From: Mark Brown <broonie@kernel.org>
To: Brandon Cheo Fusi <fusibrandon13@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regmap: add regmap_update_bits variant to autoshift mask
Date: Mon, 6 Nov 2023 16:54:37 +0000 [thread overview]
Message-ID: <ZUkaTcV9cYxKjmap@finisterre.sirena.org.uk> (raw)
In-Reply-To: <20231106163406.33952-1-fusibrandon13@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 402 bytes --]
On Mon, Nov 06, 2023 at 05:34:06PM +0100, Brandon Cheo Fusi wrote:
> +static inline int regmap_update_bits_autoshift_val(struct regmap *map, unsigned int reg,
> + unsigned int mask, unsigned int val)
> +{
Really not a fan of the name here, and in any case if the shifting of
the value is an issue wouldn't this be a good case for using a field?
Please also add kunit testcases for new APIs.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-11-06 16:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 16:34 Brandon Cheo Fusi
2023-11-06 16:54 ` Mark Brown [this message]
[not found] ` <CAEVJM+q5TgYr01MhKe9AUzpt4fj8SAWiQNE7SkX5wVTFeaoAvA@mail.gmail.com>
2023-11-08 14:33 ` Fwd: " Brandon Cheo Fusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUkaTcV9cYxKjmap@finisterre.sirena.org.uk \
--to=broonie@kernel.org \
--cc=fusibrandon13@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®