mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Edward Adam Davis <eadavis@qq.com>
Cc: bvanassche@acm.org, axboe@kernel.dk, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	syzbot+fcc47ba2476570cbbeb0@syzkaller.appspotmail.com,
	syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH V2] blk-mq: fix warning in blk_mq_start_request
Date: Tue, 7 Nov 2023 23:26:28 -0800	[thread overview]
Message-ID: <ZUs4JIu0NBz2RWys@infradead.org> (raw)
In-Reply-To: <tencent_6E1A9EAE1BB04B3A1B592506BAEABB313308@qq.com>

On Wed, Nov 08, 2023 at 02:59:40PM +0800, Edward Adam Davis wrote:
> Before call queue_rq(), initialize rq->state to MQ_RQ_IDLE.

Request should never be able to be allocated if they aren't in
MQ_RQ_IDLE.  So papering over it here is not the right fix, we need
to figure out got it ends up being marked free in the bitmap while
not idle.


  parent reply	other threads:[~2023-11-08  7:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-07  7:29 [syzbot] [block?] WARNING " syzbot
     [not found] ` <tencent_03A5938DE6921DDDE9DD921956CFAD0DE007@qq.com>
2023-11-08  5:26   ` [PATCH] null_blk: fix warning " Bart Van Assche
     [not found]     ` <tencent_6E1A9EAE1BB04B3A1B592506BAEABB313308@qq.com>
2023-11-08  7:26       ` Christoph Hellwig [this message]
2023-11-08  6:40   ` Chaitanya Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZUs4JIu0NBz2RWys@infradead.org \
    --to=hch@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=eadavis@qq.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzbot+fcc47ba2476570cbbeb0@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome