mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yujie Liu <yujie.liu@intel.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Waiman Long <longman@redhat.com>,
	kernel test robot <lkp@intel.com>,
	<oe-kbuild-all@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
	Tejun Heo <tj@kernel.org>
Subject: Re: kernel/cgroup/debug.c:1: warning: no structured comments found
Date: Wed, 22 Nov 2023 10:08:10 +0800	[thread overview]
Message-ID: <ZV1iimYpmpk9LZWS@yujie-X299> (raw)
In-Reply-To: <2a4813ff-54a7-49b0-8d18-4cb54621e637@infradead.org>

On Mon, Nov 20, 2023 at 08:11:07PM -0800, Randy Dunlap wrote:
> Hi,
> 
> On 11/20/23 19:04, Waiman Long wrote:
> > 
> > On 11/20/23 21:32, kernel test robot wrote:
> >> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> >> head:   98b1cc82c4affc16f5598d4fa14b1858671b2263
> >> commit: a28f8f5e995fe5964ae304444913536058f26e37 cgroup: Move debug cgroup to its own file
> >> date:   6 years ago
> >> config: i386-buildonly-randconfig-005-20231120 (https://download.01.org/0day-ci/archive/20231121/202311211005.Qwt1FHrO-lkp@intel.com/config)
> >> compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
> >> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231121/202311211005.Qwt1FHrO-lkp@intel.com/reproduce)
> >>
> >> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> >> the same patch/commit), kindly add following tags
> >> | Reported-by: kernel test robot <lkp@intel.com>
> >> | Closes: https://lore.kernel.org/oe-kbuild-all/202311211005.Qwt1FHrO-lkp@intel.com/
> >>
> >> All warnings (new ones prefixed by >>):
> >>
> >>>> kernel/cgroup/debug.c:1: warning: no structured comments found
> >>
> >> vim +1 kernel/cgroup/debug.c
> >>
> >>     > 1    #include <linux/ctype.h>
> >>       2    #include <linux/mm.h>
> >>       3    #include <linux/slab.h>
> >>       4   
> > 
> > Yes, there is no function in this file with structure comments. This debug controller is used for debugging only and is not supposed to be used on production systems anyway. Its interface is unstable and so I don't see a need to properly document its interface.
> > 
> > I will leave this file as it is for now.
> 
> Yes :)
> 
> 
> This warning usually happens when some file is referenced in the
> Documentation/ tree while building 'make htmldocs', e.g.
> 
> But this source file is not used in Documentation/ at all,
> so this report seems to have some kind of a problem.
> Also, I could not reproduce the warning.

Thanks for the information. We've configured the bot to ignore this
warning. Sorry for the noise.

Best Regards,
Yujie

      reply	other threads:[~2023-11-22  2:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-21  2:32 kernel test robot
2023-11-21  3:04 ` Waiman Long
2023-11-21  4:11   ` Randy Dunlap
2023-11-22  2:08     ` Yujie Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZV1iimYpmpk9LZWS@yujie-X299 \
    --to=yujie.liu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=longman@redhat.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=rdunlap@infradead.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®