From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Nikita Shubin <nikita.shubin@maquefel.me>
Cc: Sebastian Reichel <sre@kernel.org>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Alexander Sverdlin <alexander.sverdlin@gmail.com>
Subject: Re: [PATCH v5 05/39] power: reset: Add a driver for the ep93xx reset
Date: Wed, 22 Nov 2023 13:53:51 +0200 [thread overview]
Message-ID: <ZV3rz8-AGGEGGi1g@smile.fi.intel.com> (raw)
In-Reply-To: <20231122-ep93xx-v5-5-d59a76d5df29@maquefel.me>
On Wed, Nov 22, 2023 at 11:59:43AM +0300, Nikita Shubin wrote:
> Implement the reset behaviour of the various EP93xx SoCS in drivers/power/reset.
>
> It used to be located in arch/arm/mach-ep93xx.
...
> +#include <linux/bits.h>
> +#include <linux/delay.h>
> +#include <linux/mfd/syscon.h>
> +#include <linux/notifier.h>
> +#include <linux/of.h>
I believe I already had commented in one of the previous rounds that this cargo
cult of adding of.h (esp. if it's used as a proxy) is not a good idea. Please,
revisit _ALL_ (and I mean it) your patches for this kind of issues.
...
> +#include <linux/reboot.h>
> +
> +#include <linux/soc/cirrus/ep93xx.h>
You see, here is a blank line, so I suggest keep it in all your patches for
consistency's sake.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-11-22 12:03 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 8:59 [PATCH v5 00/39] ep93xx device tree conversion Nikita Shubin via B4 Relay
2023-11-22 8:59 ` [PATCH v5 01/39] gpio: ep93xx: split device in multiple Nikita Shubin via B4 Relay
2023-11-22 11:23 ` Andy Shevchenko
2023-11-22 8:59 ` [PATCH v5 02/39] ARM: ep93xx: add regmap aux_dev Nikita Shubin via B4 Relay
2023-11-22 8:59 ` [PATCH v5 03/39] clk: ep93xx: add DT support for Cirrus EP93xx Nikita Shubin via B4 Relay
2023-11-22 11:39 ` Andy Shevchenko
2023-11-22 8:59 ` [PATCH v5 04/39] pinctrl: add a Cirrus ep93xx SoC pin controller Nikita Shubin via B4 Relay
2023-11-22 11:50 ` Andy Shevchenko
2023-11-22 8:59 ` [PATCH v5 05/39] power: reset: Add a driver for the ep93xx reset Nikita Shubin via B4 Relay
2023-11-22 11:53 ` Andy Shevchenko [this message]
2023-11-22 8:59 ` [PATCH v5 06/39] dt-bindings: soc: Add Cirrus EP93xx Nikita Shubin via B4 Relay
2023-11-27 20:18 ` Rob Herring
2023-12-11 11:46 ` Nikita Shubin
2023-11-22 8:59 ` [PATCH v5 07/39] soc: Add SoC driver for Cirrus ep93xx Nikita Shubin via B4 Relay
2023-11-22 12:01 ` Andy Shevchenko
2023-11-22 8:59 ` [PATCH v5 08/39] dt-bindings: dma: Add Cirrus EP93xx Nikita Shubin via B4 Relay
2023-11-22 11:02 ` Rob Herring
2023-11-22 15:44 ` Rob Herring
2023-11-22 18:26 ` Krzysztof Kozlowski
2023-11-22 8:59 ` [PATCH v5 09/39] dma: cirrus: add DT support for " Nikita Shubin via B4 Relay
2023-11-22 12:10 ` Andy Shevchenko
2023-11-22 8:59 ` [PATCH v5 10/39] dt-bindings: watchdog: Add Cirrus EP93x Nikita Shubin via B4 Relay
2023-11-22 8:59 ` [PATCH v5 11/39] watchdog: ep93xx: add DT support for Cirrus EP93xx Nikita Shubin via B4 Relay
2023-11-22 8:59 ` [PATCH v5 12/39] dt-bindings: pwm: Add " Nikita Shubin via B4 Relay
2023-11-22 18:27 ` Krzysztof Kozlowski
2023-11-22 8:59 ` [PATCH v5 13/39] pwm: ep93xx: add DT support for " Nikita Shubin via B4 Relay
2023-11-22 8:59 ` [PATCH v5 14/39] dt-bindings: spi: Add " Nikita Shubin via B4 Relay
2023-11-22 12:03 ` Mark Brown
2023-11-22 8:59 ` [PATCH v5 15/39] spi: ep93xx: add DT support for " Nikita Shubin via B4 Relay
2023-12-01 20:18 ` Mark Brown
2023-11-22 8:59 ` [PATCH v5 16/39] dt-bindings: net: Add " Nikita Shubin via B4 Relay
2023-11-22 11:02 ` Rob Herring
2023-11-22 8:59 ` [PATCH v5 17/39] net: cirrus: add DT support for " Nikita Shubin via B4 Relay
2023-11-22 12:16 ` Andy Shevchenko
2023-12-08 11:10 ` Nikita Shubin
2023-11-22 8:59 ` [PATCH v5 18/39] dt-bindings: mtd: Add ts7200 nand-controller Nikita Shubin via B4 Relay
2023-11-22 11:02 ` Rob Herring
2023-11-22 8:59 ` [PATCH v5 19/39] mtd: rawnand: add support for ts72xx Nikita Shubin via B4 Relay
2023-11-22 12:24 ` Andy Shevchenko
2023-11-22 13:08 ` Miquel Raynal
2023-12-08 11:24 ` Nikita Shubin
2023-12-08 11:33 ` Miquel Raynal
2023-11-22 8:59 ` [PATCH v5 20/39] dt-bindings: ata: Add Cirrus EP93xx Nikita Shubin via B4 Relay
2023-11-22 11:02 ` Rob Herring
2023-11-22 8:59 ` [PATCH v5 21/39] ata: pata_ep93xx: add device tree support Nikita Shubin via B4 Relay
2023-11-22 12:25 ` Andy Shevchenko
2023-11-22 9:00 ` [PATCH v5 22/39] dt-bindings: input: Add Cirrus EP93xx keypad Nikita Shubin via B4 Relay
2023-11-22 11:02 ` Rob Herring
2023-11-22 9:00 ` [PATCH v5 23/39] input: keypad: ep93xx: add DT support for Cirrus EP93xx Nikita Shubin via B4 Relay
2023-11-22 9:00 ` [PATCH v5 24/39] dt-bindings: wdt: Add ts72xx Nikita Shubin via B4 Relay
2023-11-22 11:02 ` Rob Herring
2023-11-22 9:00 ` [PATCH v5 25/39] wdt: ts72xx: add DT support for ts72xx Nikita Shubin via B4 Relay
2023-11-22 9:00 ` [PATCH v5 26/39] gpio: ep93xx: add DT support for gpio-ep93xx Nikita Shubin via B4 Relay
2023-11-22 9:00 ` [PATCH v5 27/39] ASoC: dt-bindings: ep93xx: Document DMA support Nikita Shubin via B4 Relay
2023-11-22 11:02 ` Rob Herring
2023-11-22 12:05 ` Mark Brown
2023-11-22 18:47 ` Krzysztof Kozlowski
2023-11-22 9:00 ` [PATCH v5 28/39] ASoC: dt-bindings: ep93xx: Document Audio Port support Nikita Shubin via B4 Relay
2023-11-22 11:02 ` Rob Herring
2023-11-22 18:49 ` Krzysztof Kozlowski
2023-11-22 9:00 ` [PATCH v5 29/39] ASoC: ep93xx: Drop legacy DMA support Nikita Shubin via B4 Relay
2023-11-22 12:07 ` Mark Brown
2023-11-22 9:00 ` [PATCH v5 30/39] ARM: dts: add Cirrus EP93XX SoC .dtsi Nikita Shubin via B4 Relay
2023-11-22 9:00 ` [PATCH v5 31/39] ARM: dts: ep93xx: add ts7250 board Nikita Shubin via B4 Relay
2023-11-22 9:00 ` [PATCH v5 32/39] ARM: dts: ep93xx: Add EDB9302 DT Nikita Shubin via B4 Relay
2023-11-22 9:00 ` [PATCH v5 33/39] ARM: ep93xx: DT for the Cirrus ep93xx SoC platforms Nikita Shubin via B4 Relay
2023-11-22 14:02 ` Alexander Sverdlin
2023-11-22 9:00 ` [PATCH v5 34/39] pwm: ep93xx: drop legacy pinctrl Nikita Shubin via B4 Relay
2023-11-22 9:00 ` [PATCH v5 35/39] ata: pata_ep93xx: remove legacy pinctrl use Nikita Shubin via B4 Relay
2023-11-22 12:28 ` Andy Shevchenko
2023-11-22 9:00 ` [PATCH v5 36/39] ARM: ep93xx: delete all boardfiles Nikita Shubin via B4 Relay
2023-11-22 9:00 ` [PATCH v5 37/39] ARM: ep93xx: soc: drop defines Nikita Shubin via B4 Relay
2023-11-22 9:00 ` [PATCH v5 38/39] ASoC: cirrus: edb93xx: Delete driver Nikita Shubin via B4 Relay
2023-11-22 9:00 ` [PATCH v5 39/39] dma: cirrus: remove platform code Nikita Shubin via B4 Relay
2023-11-22 12:31 ` Andy Shevchenko
2023-12-11 12:10 ` Nikita Shubin
2023-11-22 10:26 ` [PATCH v5 00/39] ep93xx device tree conversion Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZV3rz8-AGGEGGi1g@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=alexander.sverdlin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nikita.shubin@maquefel.me \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®