From: Andi Shyti <andi.shyti@linux.intel.com>
To: "wuqiang.matt" <wuqiang.matt@bytedance.com>
Cc: ubizjak@gmail.com, mark.rutland@arm.com, vgupta@kernel.org,
bcain@quicinc.com, jonas@southpole.se,
stefan.kristiansson@saunalahti.fi, shorne@gmail.com,
chris@zankel.net, jcmvbkbc@gmail.com, geert@linux-m68k.org,
andi.shyti@linux.intel.com, mingo@kernel.org,
palmer@rivosinc.com, andrzej.hajda@intel.com, arnd@arndb.de,
peterz@infradead.org, mhiramat@kernel.org,
linux-arch@vger.kernel.org, linux-snps-arc@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-hexagon@vger.kernel.org,
linux-openrisc@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, mattwu@163.com,
linux@roeck-us.net
Subject: Re: [PATCH v3 1/5] arch,locking/atomic: arc: arch_cmpxchg should check data size
Date: Wed, 22 Nov 2023 23:17:07 +0100 [thread overview]
Message-ID: <ZV594z0bNQR-vo2b@ashyti-mobl2.lan> (raw)
In-Reply-To: <20231121142347.241356-2-wuqiang.matt@bytedance.com>
Hi Wuqiang,
On Tue, Nov 21, 2023 at 10:23:43PM +0800, wuqiang.matt wrote:
> arch_cmpxchg() should check data size rather than pointer size in case
> CONFIG_ARC_HAS_LLSC is defined. So rename __cmpxchg to __cmpxchg_32 to
> emphasize it's explicit support of 32bit data size with BUILD_BUG_ON()
> added to avoid any possible misuses with unsupported data types.
>
> In case CONFIG_ARC_HAS_LLSC is undefined, arch_cmpxchg() uses spinlock
> to accomplish SMP-safety, so the BUILD_BUG_ON checking is uncecessary.
>
> v2 -> v3:
> - Patches regrouped and has the improvement for xtensa included
> - Comments refined to address why these changes are needed
>
> v1 -> v2:
> - Try using native cmpxchg variants if avaialble, as Arnd advised
>
> Signed-off-by: wuqiang.matt <wuqiang.matt@bytedance.com>
> Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> ---
> arch/arc/include/asm/cmpxchg.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arc/include/asm/cmpxchg.h b/arch/arc/include/asm/cmpxchg.h
> index e138fde067de..bf46514f6f12 100644
> --- a/arch/arc/include/asm/cmpxchg.h
> +++ b/arch/arc/include/asm/cmpxchg.h
> @@ -18,14 +18,16 @@
> * if (*ptr == @old)
> * *ptr = @new
> */
> -#define __cmpxchg(ptr, old, new) \
> +#define __cmpxchg_32(ptr, old, new) \
> ({ \
> __typeof__(*(ptr)) _prev; \
> \
> + BUILD_BUG_ON(sizeof(*(ptr)) != 4); \
> + \
> __asm__ __volatile__( \
> - "1: llock %0, [%1] \n" \
> + "1: llock %0, [%1] \n" \
> " brne %0, %2, 2f \n" \
> - " scond %3, [%1] \n" \
> + " scond %3, [%1] \n" \
> " bnz 1b \n" \
> "2: \n" \
> : "=&r"(_prev) /* Early clobber prevent reg reuse */ \
> @@ -47,7 +49,7 @@
> \
> switch(sizeof((_p_))) { \
> case 4: \
> - _prev_ = __cmpxchg(_p_, _o_, _n_); \
> + _prev_ = __cmpxchg_32(_p_, _o_, _n_); \
> break; \
> default: \
> BUILD_BUG(); \
> @@ -65,8 +67,6 @@
> __typeof__(*(ptr)) _prev_; \
> unsigned long __flags; \
> \
> - BUILD_BUG_ON(sizeof(_p_) != 4); \
> - \
I think I made some comments here that have not been addressed or
replied.
Thanks,
Andi
> /* \
> * spin lock/unlock provide the needed smp_mb() before/after \
> */ \
> --
> 2.40.1
next prev parent reply other threads:[~2023-11-22 22:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 14:23 [PATCH v3 0/5] arch,locking/atomic: add arch_cmpxchg[64]_local wuqiang.matt
2023-11-21 14:23 ` [PATCH v3 1/5] arch,locking/atomic: arc: arch_cmpxchg should check data size wuqiang.matt
2023-11-22 22:17 ` Andi Shyti [this message]
2023-11-23 0:06 ` wuqiang.matt
2023-11-21 14:23 ` [PATCH v3 2/5] arch,locking/atomic: arc: add arch_cmpxchg[64]_local wuqiang.matt
2023-11-21 14:23 ` [PATCH v3 3/5] arch,locking/atomic: openrisc: " wuqiang.matt
2023-11-21 14:23 ` [PATCH v3 4/5] arch,locking/atomic: hexagon: " wuqiang.matt
2023-11-21 14:23 ` [PATCH v3 5/5] arch,locking/atomic: xtensa: define arch_cmpxchg_local as __cmpxchg_local wuqiang.matt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZV594z0bNQR-vo2b@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=andrzej.hajda@intel.com \
--cc=arnd@arndb.de \
--cc=bcain@quicinc.com \
--cc=chris@zankel.net \
--cc=geert@linux-m68k.org \
--cc=jcmvbkbc@gmail.com \
--cc=jonas@southpole.se \
--cc=linux-arch@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=mattwu@163.com \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=palmer@rivosinc.com \
--cc=peterz@infradead.org \
--cc=shorne@gmail.com \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=ubizjak@gmail.com \
--cc=vgupta@kernel.org \
--cc=wuqiang.matt@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®