From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF8A8C4167D for ; Tue, 14 Nov 2023 13:27:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233061AbjKNN2A (ORCPT ); Tue, 14 Nov 2023 08:28:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231203AbjKNN16 (ORCPT ); Tue, 14 Nov 2023 08:27:58 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 861F71A1; Tue, 14 Nov 2023 05:27:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699968475; x=1731504475; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=d5U20eRXmG1QWxY9GBKXPXoLC/XUzDWALfgg1Q5yC04=; b=jg2VpkU08BQFiKxzk5Mq6q3hAUCaSDNb2tG8E5KRP/rNEGXZamECfC/8 0UMut3hetU/g6ZhRfgShSdeBGBerio1J38d+6F5on0zB8hAY3A8rjYt4G gJPVhUehg3H8BeaIqN5O/kRxgfbguzwnVFR7yt/tBj/b7e+oyNTChKUjD hmIo77Mj2odONoKLqZi5F1O2+K7RqyBjd9ZaxqzAYOCVp4HOnCM8Rn/Ls i4jNTAmzH7BwOLk7uXSU5tbUbCoto+/5dtarWK1RgE1mrFz9FYU1O4IyF Ef3dq47lfqDpvWCFBoWUhlZwUgsPWwb/WHBX262OBKkB1Ln0KO315VO12 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10894"; a="421751295" X-IronPort-AV: E=Sophos;i="6.03,302,1694761200"; d="scan'208";a="421751295" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2023 05:27:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10894"; a="741092612" X-IronPort-AV: E=Sophos;i="6.03,302,1694761200"; d="scan'208";a="741092612" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga006.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2023 05:27:47 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC3) (envelope-from ) id 1r2tSB-0000000Dp3m-3h5E; Tue, 14 Nov 2023 15:27:43 +0200 Date: Tue, 14 Nov 2023 15:27:43 +0200 From: Andy Shevchenko To: Herve Codina Cc: Saravana Kannan , Petr Mladek , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Sakari Ailus , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Allan Nielsen , Horatiu Vultur , Steen Hegelund , Thomas Petazzoni , stable@vger.kernel.org Subject: Re: [PATCH 1/1] lib/vsprintf: Fix %pfwf when current node refcount == 0 Message-ID: References: <20231114110456.273844-1-herve.codina@bootlin.com> <20231114141934.1b0d44e2@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231114141934.1b0d44e2@bootlin.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 14, 2023 at 02:19:34PM +0100, Herve Codina wrote: > On Tue, 14 Nov 2023 15:12:47 +0200 > Andy Shevchenko wrote: > > On Tue, Nov 14, 2023 at 12:04:56PM +0100, Herve Codina wrote: > > > A refcount issue can appeared in __fwnode_link_del() due to the > > > pr_debug() call: ---8<--- > > > WARNING: CPU: 0 PID: 901 at lib/refcount.c:25 refcount_warn_saturate+0xe5/0x110 > > > Call Trace: > > > ? refcount_warn_saturate+0xe5/0x110 ... > > > of_node_get+0x1e/0x30 > > > of_fwnode_get+0x28/0x40 > > > fwnode_full_name_string+0x34/0x90 > > > fwnode_string+0xdb/0x140 ... > > > vsnprintf+0x17b/0x630 ... > > > __fwnode_link_del+0x25/0xa0 > > > fwnode_links_purge+0x39/0xb0 > > > of_node_release+0xd9/0x180 ... ---8<--- > > Please, do not put so many unrelated lines of backtrace in the commit message. > > Leave only the important ones (the Submitting Patches document suggests some > > like ~3-5 lines only). > > Ok, I will remove some of them. Thanks (my suggestion is above). -- With Best Regards, Andy Shevchenko