From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 1E25DC54FB9
	for <linux-kernel@archiver.kernel.org>; Sun, 19 Nov 2023 21:00:34 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231514AbjKSVAe (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Sun, 19 Nov 2023 16:00:34 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57938 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229607AbjKSVAc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 19 Nov 2023 16:00:32 -0500
Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8D30E0
        for <linux-kernel@vger.kernel.org>; Sun, 19 Nov 2023 13:00:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=ewgYBVW+Iax6CqzUrSGGjtpzlAkAA8ZMF03lgMpKaIM=; b=L7I4eUqhsu4ZZE1SCodP+CJCa5
        lYRdOOhI8LmR0CCIKa3wU5+7oLM/bhCZcjFmXsE2EfXVh5IrKBhX+la7+E9OeSncmFHwfi6/5jrJF
        M4ayq94GPqv3jN2o6ub8xvP3YV3p/v1N6H6fhVNDsNQvNcwWG++4ngyUKPQtJft61+hp6P4PcZXD/
        M1r/cPpOU+6yynFEkLk5FXGmolrrwfxMKQssZIULatYKHlIy6oIEY0fgrud9V8vigjqGNTAnQmu91
        26WPxjLWmrrz99hjnHnjkMe7wAl2aYvKkb/VuGRHZunrgggQMzkBX9EVYZAyeODiVaNNNRBMSxxfL
        BQasstSw==;
Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux))
        id 1r4otl-0032p2-JP; Sun, 19 Nov 2023 21:00:09 +0000
Date:   Sun, 19 Nov 2023 21:00:09 +0000
From:   Matthew Wilcox <willy@infradead.org>
To:     Kairui Song <kasong@tencent.com>
Cc:     linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
        "Huang, Ying" <ying.huang@intel.com>,
        David Hildenbrand <david@redhat.com>,
        Hugh Dickins <hughd@google.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@suse.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/24] mm/swap: move no readahead swapin code to a stand
 alone helper
Message-ID: <ZVp3WR+D4Z/UZEqO@casper.infradead.org>
References: <20231119194740.94101-1-ryncsn@gmail.com>
 <20231119194740.94101-4-ryncsn@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231119194740.94101-4-ryncsn@gmail.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 20, 2023 at 03:47:19AM +0800, Kairui Song wrote:
> +			/* skip swapcache and readahead */
> +			page = swapin_no_readahead(entry, GFP_HIGHUSER_MOVABLE,
> +						vmf);
> +			if (page)
> +				folio = page_folio(page);

I think this should rather be:

			folio = swapin_no_readahead(entry,
					GFP_HIGHUSER_MOVABLE, vma);
			page = &folio->page;

and have swapin_no_readahead() work entirely in terms of folios.