From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Takashi Iwai <tiwai@suse.de>, Hans de Goede <hdegoede@redhat.com>
Cc: "Thorsten Leemhuis" <regressions@leemhuis.info>,
"Jean-Jacques Hiblot" <jjhiblot@traphandler.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Linux Regressions" <regressions@lists.linux.dev>,
"Linux LEDs" <linux-leds@vger.kernel.org>,
"Tim Crawford" <tcrawford@system76.com>,
"Jeremy Soller" <jeremy@system76.com>,
"System76 Product Development" <productdev@system76.com>,
"Lee Jones" <lee@kernel.org>, "Pavel Machek" <pavel@ucw.cz>,
"Johannes Penßel" <johannes.penssel@gmail.com>
Subject: Re: Fwd: sysfs: cannot create duplicate filename .../system76_acpi::kbd_backlight/color
Date: Tue, 21 Nov 2023 18:45:20 +0700 [thread overview]
Message-ID: <ZVyYUPei6_YP-g94@archie.me> (raw)
In-Reply-To: <874jhfo0oc.wl-tiwai@suse.de>
[-- Attachment #1: Type: text/plain, Size: 3537 bytes --]
On Tue, Nov 21, 2023 at 11:33:55AM +0100, Takashi Iwai wrote:
> On Tue, 21 Nov 2023 11:21:53 +0100,
> Hans de Goede wrote:
> >
> > Hi,
> >
> > On 11/21/23 10:52, Takashi Iwai wrote:
> > > On Tue, 21 Nov 2023 10:19:03 +0100,
> > > Thorsten Leemhuis wrote:
> > >>
> > >> Takashi, Jean-Jacques Hiblot, Lee,
> > >>
> > >> On 20.11.23 14:53, Takashi Iwai wrote:
> > >>> On Mon, 06 Nov 2023 14:19:08 +0100,
> > >>> Bagas Sanjaya wrote:
> > >>>> On Sat, Nov 04, 2023 at 01:01:56PM +0100, Jean-Jacques Hiblot wrote:
> > >>>>> On 29/10/2023 02:48, Bagas Sanjaya wrote:
> > >>>>>> On Thu, Oct 26, 2023 at 02:55:06PM +0700, Bagas Sanjaya wrote:
> > >>>>>>> The culprit seems to be commit c7d80059b086c4986cd994a1973ec7a5d75f8eea, which introduces a new 'color' attribute for led sysfs class devices. The problem is that the system76-acpi platform driver tries to create the exact same sysfs attribute itself for the system76_acpi::kbd_backlight device, leading to the conflict. For testing purposes, I've just rebuilt the kernel with the system76-apci color attribute renamed to kb_color, and that fixes the issue.
> > >>>>>>
> > >>>>>> Jean-Jacques Hiblot, would you like to take a look on this regression,
> > >>>>>> since you authored the culprit?
> > >>>
> > >>>>> The offending commit stores the color in struct led_classdev and exposes it
> > >>>>> via sysfs. It was part of a series that create a RGB leds from multiple
> > >>>>> single-color LEDs. for this series, we need the color information but we
> > >>>>> don't really need to expose it it via sysfs. In order to fix the issue, we
> > >>>>> can remove the 'color' attribute from the sysfs.
> > >>>>
> > >>>> OK, see you in the patch!
> > >>>
> > >>> Is there a patch available?
> > >>
> > >> Not that I know of. Could not find anything on lore either.
> > >>
> > >>> This bug hits for a few Logitech keyboard models, too, and it makes
> > >>> 6.6 kernel unsable for them, as hid-lg-g15 driver probe fails due to
> > >>> this bug:
> > >>> https://bugzilla.kernel.org/show_bug.cgi?id=218155
> > >>>
> > >>> We need a quick fix for 6.6.x.
> > >>
> > >> Given that Jean-Jacques Hiblot (the author of the culprit) and Lee (who
> > >> committed it and sent it to Linus) know about this for a while already
> > >> without doing anything about it, I wonder if someone should just send a
> > >> revert to Linus (unless of course that is likely to introduce a
> > >> regression on its own).
> > >>
> > >> Takashi, could you maybe do this, unless a fix shows up real soon?
> > >
> > > I can, but we need to decide which way to go.
> > > There are several options:
> > >
> > > 1. Revert the commit c7d80059b086;
> > > this drops led class color sysfs entries. Also the store of
> > > led_cdev->color from fwnode is dropped, too.
> > >
> > > 2. Drop only led class color sysfs entries;
> > > a partial revert of c7d80059b086 above
> >
> > AFAIK further up in the thread (or a related thread) there
> > already was consensus to do this. Someone just needs to
> > write the patch.
>
> Well, is there any user of this new led_classdev.color field?
> The value read from fwnode is stored there, but as far as I see, there
> seems no real user, so far. If it's still unused, we can do the whole
> revert -- which is cleaner.
ACK for the revert. The original commit should have been designed to
not have sysfs conflict like this, though.
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-11-21 11:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 7:55 Bagas Sanjaya
2023-10-29 1:48 ` Bagas Sanjaya
2023-11-04 12:01 ` Jean-Jacques Hiblot
2023-11-06 13:19 ` Bagas Sanjaya
2023-11-20 13:53 ` Takashi Iwai
2023-11-21 9:19 ` Thorsten Leemhuis
2023-11-21 9:52 ` Takashi Iwai
2023-11-21 9:56 ` Takashi Iwai
2023-11-21 10:21 ` Hans de Goede
2023-11-21 10:33 ` Takashi Iwai
2023-11-21 11:45 ` Bagas Sanjaya [this message]
2023-11-21 12:23 ` Hans de Goede
2023-11-21 14:26 ` Takashi Iwai
2023-11-21 15:15 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVyYUPei6_YP-g94@archie.me \
--to=bagasdotme@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jeremy@system76.com \
--cc=jjhiblot@traphandler.com \
--cc=johannes.penssel@gmail.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=productdev@system76.com \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
--cc=tcrawford@system76.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®