From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5030DC61D85 for ; Tue, 21 Nov 2023 15:03:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234829AbjKUPD4 (ORCPT ); Tue, 21 Nov 2023 10:03:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234521AbjKUPDz (ORCPT ); Tue, 21 Nov 2023 10:03:55 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABCEAD1 for ; Tue, 21 Nov 2023 07:03:51 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47AD6C433C8; Tue, 21 Nov 2023 15:03:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700579031; bh=ybjDzxPZW5g+QhZul9Du8UCGPjKVYHmIO/KEc0Aw7YQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oGnUEJcGjCJUadWNW4WUkZSR3cMzcCee54zegnUDA8ilcTUNmGunCdv+Q9IDr4+Mw iACpM2DWBIvBGGHfC//8xFf0Mqq7wLY198e8tWfMB5VxPqYg3iKKmGqjWDAmDm+R+A JJs27it0sDCvJQJ6EWHm1gdt3kX2qCkXB4SWd06ox8GubkZ1FMC0/hqK1ttsjVLnUZ ki975Q/Qp7qFubmCb3G4lLk4jUogBtOezEN0QV0+IDrXwfNDUlFs9B8axkBpN+Nb8u 4pAK3DJLq+/1sUwFzqnvDTf/JwilcTCFwrJwSP1ZFzbNRPC4w7yVApZpPRmr6ujn3l cHVxaXqno7+mg== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1r5SIF-0007xS-2C; Tue, 21 Nov 2023 16:04:03 +0100 Date: Tue, 21 Nov 2023 16:04:03 +0100 From: Johan Hovold To: Greg Kroah-Hartman Cc: Andrew Halaney , Konrad Dybcio , Johan Hovold , Andy Gross , Bjorn Andersson , Thinh Nguyen , Krishna Kurapati PSSNV , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] USB: dwc3: qcom: fix resource leaks on probe deferral Message-ID: References: <20231117173650.21161-1-johan+linaro@kernel.org> <041f239f-7b40-4681-8c6c-2268f9c2c684@linaro.org> <74cswe5tivcctmnty3gfavzsxdvjz5m4rktyj5auzwvrndninm@dah4h2fdj3zv> <2023112124-duckling-absinthe-2167@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2023112124-duckling-absinthe-2167@gregkh> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 21, 2023 at 03:21:34PM +0100, Greg Kroah-Hartman wrote: > On Mon, Nov 20, 2023 at 05:53:10PM +0100, Johan Hovold wrote: > > On Mon, Nov 20, 2023 at 09:22:54AM -0600, Andrew Halaney wrote: > > > On Sat, Nov 18, 2023 at 12:47:30AM +0100, Konrad Dybcio wrote: > > > > On 17.11.2023 18:36, Johan Hovold wrote: > > > > > When reviewing the recently submitted series which reworks the dwc3 qcom > > > > > glue implementation [1], I noticed that the driver's tear down handling > > > > > is currently broken, something which can lead to memory leaks and > > > > > potentially use-after-free issues on probe deferral and on driver > > > > > unbind. > > > > > > > > > > Let's get this sorted before reworking driver. > > > > > > > > > > Note that the last patch has only been compile tested as I don't have > > > > > access to a sdm845 device. > > > > > > I'll sound like a broken record, but: > > > > > > > > is there anyone in the world that is actively benefiting from this failed > > > > experiment of using the ACPI tables that were shipped with these SoCs? > > I agree that if we can remove the ACPI hacks in here, we should try do > > so (e.g. given that no one really uses it anymore). > > > > As Andrew already mentioned, that is a separate issue not directly > > related to this series, though. > > > > Removing it before reworking the dwc3 binding [1] and adding multiport > > support [2] should simplify both of those series quite a bit, however. > > [1] https://lore.kernel.org/all/20231016-dwc3-refactor-v1-0-ab4a84165470@quicinc.com/ > > [2] https://lore.kernel.org/all/20231007154806.605-1-quic_kriskura@quicinc.com/ > > > > So should I apply this series now or not? Please do. Removing ACPI support should be done later if that's at all possible. Johan