From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CCCEC4167B for ; Mon, 4 Dec 2023 13:00:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344093AbjLDM77 (ORCPT ); Mon, 4 Dec 2023 07:59:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232947AbjLDM75 (ORCPT ); Mon, 4 Dec 2023 07:59:57 -0500 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B61E4AC for ; Mon, 4 Dec 2023 05:00:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701694804; x=1733230804; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Y2GfyXQZuFvt44HpNbFO8Dio1945GQvhrWWBFMeblpg=; b=NK2Xa/LBs5fi966YKG1RFAhJRJYqd/xBIW4FWspJMByWqgCBRyAAbuCw aqtXtAE1AjcXny6Es+Xn3gH8fWqIR3kNDcIV4d6w/T7SdXgs8c7fZ8IeA +luYl6risJ2UkB6GtKSIvisNnc1Y24a8NYqIs+pFdBVAoAM2EZXIhEhir BsSYy8Dt94DZqNfYOST67DU1skgiZpC/szNx/Znj1X7YvXeXe3SbGpe3p qxW8MBEnh6k/B8B6sdeF3XwPMyUUN2CIDeqDnHgRhp1K6kFsEdPUxQCPh Yus4d2mDUi9eJNSi6Az/ucfvKj/CsOy8PylmaPVf3jpCnP8hG/JsxG/Pv Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10913"; a="780594" X-IronPort-AV: E=Sophos;i="6.04,249,1695711600"; d="scan'208";a="780594" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 05:00:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10913"; a="836576672" X-IronPort-AV: E=Sophos;i="6.04,249,1695711600"; d="scan'208";a="836576672" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 05:00:01 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rA8YI-00000001kmJ-1XMq; Mon, 04 Dec 2023 14:59:58 +0200 Date: Mon, 4 Dec 2023 14:59:58 +0200 From: Andy Shevchenko To: Joe Perches Cc: Guenter Roeck , Andrew Morton , linux-kernel@vger.kernel.org, Andy Whitcroft , Dwaipayan Ray , Lukas Bulwahn Subject: Re: [PATCH v1 1/1] checkpatch: Add dev_err_probe() to the list of Log Functions Message-ID: References: <20231201151446.1593472-1-andriy.shevchenko@linux.intel.com> <3c709cc1-0da8-4d23-9f75-8c18d4d18779@roeck-us.net> <8fff7625-69b7-4c32-a3bb-d3ca24f149bf@roeck-us.net> <8d846c564461af99c27d81a69888d73f3622de8b.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8d846c564461af99c27d81a69888d73f3622de8b.camel@perches.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 01, 2023 at 02:29:57PM -0800, Joe Perches wrote: > On Fri, 2023-12-01 at 19:07 +0200, Andy Shevchenko wrote: > > Currently the [style] behaviour is > > inconsistent independently on somebody's preferences... > > Which is IMO perfectly fine. > > The ratio of multiple line and single line uses > of dev_err_probe is ~50:50 > > $ git grep -w dev_err_probe | grep -P ';\s*$' | wc -l > 1532 > $ git grep -w dev_err_probe | grep -P ',\s*$' | wc -l > 1871 My point is that checkpatch won't warn on dev_err(..., "very long line\n"); while doing the same on dev_err_probe() even if the line is shorter than in dev_err() case. This inconsistency I am talking about. -- With Best Regards, Andy Shevchenko