mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: SeongJae Park <sj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	damon@lists.linux.dev, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] mm/damon: export DAMON symbols and add sample loadable modules
Date: Mon, 4 Dec 2023 21:12:47 -0800	[thread overview]
Message-ID: <ZW6xTyyl0qvcqi3O@infradead.org> (raw)
In-Reply-To: <20231205022858.1540-1-sj@kernel.org>

On Tue, Dec 05, 2023 at 02:28:55AM +0000, SeongJae Park wrote:
> DAMON cannot be used from loadable modules since it is not exporting its
> symbols.

And that is a good thing.  We should absolutely not allow random modules
probing MM internals.   What you posted here is basically just adding
hooks without even real in-kernel users.


  parent reply	other threads:[~2023-12-05  5:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-05  2:28 SeongJae Park
2023-12-05  2:28 ` [PATCH 1/3] mm/damon/core: export symbols for supporting " SeongJae Park
2023-12-05  2:28 ` [PATCH 2/3] samples: add working set size estimation DAMON sample module SeongJae Park
2023-12-05  2:28 ` [PATCH 3/3] samples: add proactive reclamation " SeongJae Park
2023-12-05  5:12 ` Christoph Hellwig [this message]
2023-12-05 17:23   ` [PATCH 0/3] mm/damon: export DAMON symbols and add sample loadable modules SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZW6xTyyl0qvcqi3O@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=sj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®