From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18EEEC10F05 for ; Tue, 5 Dec 2023 19:46:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232090AbjLETqp (ORCPT ); Tue, 5 Dec 2023 14:46:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230400AbjLETqo (ORCPT ); Tue, 5 Dec 2023 14:46:44 -0500 Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2CEDC9; Tue, 5 Dec 2023 11:46:50 -0800 (PST) Received: from francesco-nb.int.toradex.com (31-10-206-125.static.upc.ch [31.10.206.125]) by mail11.truemail.it (Postfix) with ESMTPA id F3F9C1F8F7; Tue, 5 Dec 2023 20:46:48 +0100 (CET) Date: Tue, 5 Dec 2023 20:46:43 +0100 From: Francesco Dolcini To: David Lin Cc: Francesco Dolcini , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "briannorris@chromium.org" , "kvalo@kernel.org" , Pete Hsieh Subject: Re: [EXT] Re: [PATCH v7 00/12] wifi: mwifiex: added code to support host mlme. Message-ID: References: <20231128083115.613235-1-yu-hao.lin@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 01, 2023 at 11:05:47PM +0000, David Lin wrote: > > On Tue, Nov 28, 2023 at 04:31:03PM +0800, David Lin wrote: > > > 5. Address reviewer comments. > > You should list the changes you did, something that generic is forcing the > > reviewer to compare v7 vs v6 to known what changed. > > Can I summary what should I do and hopefully I can make agreement with you: > > 1. Separate patch v7 6/12 as a single patch. > 2. Merged all other patches as a single patch for host mlme. I would suggest to proceed the following way: 1. v8 of this series should have only 2 patches - PATCH v8 1/2 : add host mle station support. - PATCH v8 2/2 : add host mle AP support. Any kind of fix on these 2 new functionalities should be squashed in these single 2 patches. No commit to add a functionality with a bug that is fixed with a follow-up commit. If you discover bugs during your testing this is great, just amend the original commit that introduced it. I am assuming that is fair to implement station and AP support in separated patches, please speak up if this is not the case. 2. PATCH v7 06/12: this should be send as a new separate patch, with a Fixes: tag and Cc:stable. > So there should be no patch v8 and only have two patches, one for host > mlme and another one to fix hostap restart issue. It's ok to have a v8, restarting another series will be even more confusing IMO. Thanks! Francesco