From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Daniel Wagner <dwagner@suse.de>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Sagi Grimberg <sagi@grimberg.me>, Hannes Reinecke <hare@suse.de>
Subject: Re: [RFC v1] nvme: add cse, ds, ms, nsze and nuse to sysfs
Date: Mon, 27 Nov 2023 08:44:52 -0700 [thread overview]
Message-ID: <ZWS5dM5FzTMr5ftO@kbusch-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20231127141857.GA25833@lst.de>
On Mon, Nov 27, 2023 at 03:18:57PM +0100, Christoph Hellwig wrote:
> On Mon, Nov 27, 2023 at 11:32:08AM +0100, Daniel Wagner wrote:
> > +static ssize_t lba_ms_show(struct device *dev, struct device_attribute *attr,
> > + char *buf)
> > +{
> > + struct nvme_ns *ns = dev_to_nvme_ns(dev);
> > +
> > + return sysfs_emit(buf, "%d\n", ns->ms);
> > +}
> > +static DEVICE_ATTR_RO(lba_ms);
>
> I'd probably spell out metadata_size, or probably even better
> metadata_bytes to match the unit postfixes elsewhere in the block code.
Should this even be an nvme specific attribute? I thought we should have
blk-integrity.c report its 'tuple_size' attribute instead. That should
work as long as we're not dealing with extended metadata at least, but
that's kind of a special format that doesn't have block layer support.
next prev parent reply other threads:[~2023-11-27 15:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 10:32 Daniel Wagner
2023-11-27 10:44 ` Keith Busch
2023-11-27 12:07 ` Daniel Wagner
2023-11-27 13:57 ` Christoph Hellwig
2023-11-27 14:18 ` Christoph Hellwig
2023-11-27 15:44 ` Keith Busch [this message]
2023-11-27 15:56 ` Christoph Hellwig
2023-11-27 16:30 ` Keith Busch
2023-11-27 16:33 ` Christoph Hellwig
2023-11-27 16:46 ` Keith Busch
2023-11-28 8:21 ` Daniel Wagner
2023-11-28 10:06 ` Sagi Grimberg
2023-11-28 13:05 ` Christoph Hellwig
2023-11-28 19:02 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWS5dM5FzTMr5ftO@kbusch-mbp.dhcp.thefacebook.com \
--to=kbusch@kernel.org \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®